Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add twint integration #388

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Conversation

resslinger
Copy link
Contributor

No description provided.

@resslinger resslinger marked this pull request as ready for review October 23, 2023 10:28
@fjbender
Copy link
Contributor

Thank you for your contribution! This looks pretty solid. Let's get our pipelines sorted and then review this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is addressed and Mollie will fixed it. So this change can be reverted, if the fix is live.

@resslinger
Copy link
Contributor Author

These changes are in production and we already have received twint transactions successfully.

@resslinger
Copy link
Contributor Author

@fjbender @boxblinkracer Any update?

@fjbender
Copy link
Contributor

fjbender commented Dec 6, 2023

Sorry for the delay here - we have a lot going on in Shopware 6 as well, and @boxblinkracer had a lot of talk to deliver on various Shopware conferences ;)

I still think this is a very solid PR and can be merged as soon as we fixed the pipeline and are gearing up for a new release. I don't expect this to happen in December, though.

Thanks for your understanding!

@boxblinkracer
Copy link
Collaborator

Hi @resslinger and @fjbender
so i've been out a while and into lots of SW6 features
again thanks for this amazing PR
i will now merge it and make sure pipe is green and correct TestRail case IDs are set :)

release is then after christmas beginning next year

@boxblinkracer boxblinkracer merged commit c6f6a90 into mollie:master Dec 8, 2023
17 of 18 checks passed
@resslinger
Copy link
Contributor Author

Hi @boxblinkracer , is a release date in planning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants