fix: Excel API exception handling. #4627

harmbrugge · 2025-01-22T12:32:05Z

Changed the excel api code so that error messages in the excel api are properly handled.
Added a more explicit error message in the XlsTableStore when writing values to excel cells.

Go to the preview server and try to download the catalogue schema using the xls api
See the error message.

updated docs in case of new feature
added/updated tests
added/updated testplan to include a test for this fix, including ref to bug using # notation

… handled correctly

hslh

Exporting all data gets the expected error message, but exporting a single table still gets me a blank page: https://preview-emx2-pr-4627.dev.molgenis.org/catalogue-demo/api/excel/Resources

sonarqubecloud · 2025-01-22T14:56:13Z

Quality Gate passed

dtroelofsprins

This is really much better!

harmbrugge added 2 commits January 22, 2025 13:19

Extracted creation of temp file from output stream, so exception gets…

a8f5e2f

… handled correctly

Added explicit error message when writing xls cell contents

edbe6cd

harmbrugge self-assigned this Jan 22, 2025

harmbrugge linked an issue Jan 22, 2025 that may be closed by this pull request

Exporting data as Excel not working #4157

Closed

harmbrugge requested review from hslh and dtroelofsprins January 22, 2025 13:51

hslh requested changes Jan 22, 2025

View reviewed changes

Fixed error handling for all xls api mappings

69186e6

harmbrugge requested a review from hslh January 22, 2025 14:43

hslh approved these changes Jan 22, 2025

View reviewed changes

dtroelofsprins approved these changes Jan 23, 2025

View reviewed changes

harmbrugge merged commit ab7be0c into master Jan 23, 2025
7 checks passed

harmbrugge deleted the fix/excel-api-error-message branch January 23, 2025 11:27