Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalogue): Add city, latitude, longitude attributes to Organisations table #4602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hslh
Copy link
Contributor

@hslh hslh commented Jan 15, 2025

What are the main changes you did

  • Add city, latitude, longitude attributes to Organisations table to accommodate mapping of attributes location, latitude, longitude from Directory Biobanks table

How to test

  • Create an entry in the Organisations table with the new attributes

Questions

  • Should semantics be added?
  • Should the list of profiles be changed?

@hslh hslh requested review from BrendaHijmans and mswertz January 15, 2025 12:14
Copy link
Contributor

@BrendaHijmans BrendaHijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding semantics: DCAT uses foaf:Agent for organisations, which has subClass foaf:Organization, which has a property org:siteAddress https://www.w3.org/TR/vocab-org/#org:siteAddress, in which you can use geo locations.

@BrendaHijmans BrendaHijmans self-requested a review January 15, 2025 15:34
Copy link
Contributor

@BrendaHijmans BrendaHijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could fill these fields from the ROR automatically, so it's correct to apply them to all profiles.

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but if we move to ROR we might need to change it again.

@BrendaHijmans
Copy link
Contributor

BrendaHijmans commented Jan 17, 2025

I approve, but if we move to ROR we might need to change it again.

ROR has: city name and id from geonames, lattitude and longitude, so this probably fits well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants