feat(tailwind): first version of RefInput to show REF as radiogroup and REF_ARRAY as checkboxgroup #4585
Conversation
mswertz
changed the title
mswertz
changed the title
…-emx2 into feat/tailwind_refinput
There was a problem hiding this comment.
At some point, it might be good to refactor this component. There is a lot of JS code in this file and we could move a lot of this to custom utility classes or variants. We could also see if some of the other button components could be merged or become a variant of the base "button" component.
There was a problem hiding this comment.
Perhaps this component could become a variant of the base button component? There is some overlap between the two and it might be better to integrate the text version as an option.
We might want to rethink the button component anyways. Ideally, there should be a few button styles that correspond to page hierarchy.
- Primary action: a button to indicate the action that has the highest priority (e.g., submit form). Depending on the theme, this usually has a filled background that is the primary theme color.
- Secondary action: a button that indicates additional actions (e.g., cancel, discard changes, etc.). This is sometimes the inverted primary theme color.
- Text: This is used for styling buttons as links or other text elements. It should not have a background style and it should behave as a hyperlink element (text decoration or underline)
|
What are the main changes you did
How to test
N.B. future enhancement could be to use a nested table to allow users who don't know what they are looking for to find what they want.