Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename table/column property to 'tags' #4283

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

joerivandervelde
Copy link
Member

@joerivandervelde joerivandervelde commented Sep 30, 2024

The 'profiles' property for tables and columns is wrong: this should be called 'tags'. The profiles are made using these tags. Renaming this would make the difference more clear, helping communication and implementation.

todo:

  • doesn't run, but difficult to trace the error (even after succesful gradle cleandb, which requires db reset inside psql)
  • migration script needed I think
  • check if more things need renaming/refactoring
  • updated profile docs
  • added/updated tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants