Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add docs links #4197

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Add docs links #4197

wants to merge 3 commits into from

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Sep 9, 2024 •
edited
Loading

What are the main changes you did:

  • Just added the links, need to discuss if we want to combine 'upload' with 'docs' links ( if zo how to we call this new link)
  • Think about adding links / other stuff to footer

how to test:

  • click the links

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug connoratrug marked this pull request as ready for review September 30, 2024 07:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@connoratrug
Copy link
Contributor Author

maybe open in new tab would be better , and maybe hide in cohortOnly context

@EleanorHyde-UMCG
Copy link
Contributor

maybe open in new tab would be better , and maybe hide in cohortOnly context

I agree that opening 'upload data' and 'manual' in a new tab each time would be more user-friendly. Not sure what you mean by cohortOnly, though?

@EleanorHyde-UMCG
Copy link
Contributor

@marijevdgeest have you seen this yet? Does this match your spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

@EleanorHyde-UMCG EleanorHyde-UMCG Awaiting requested review from EleanorHyde-UMCG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connoratrug @EleanorHyde-UMCG @mswertz