-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:cleaner dependencies #4149
base: master
Are you sure you want to change the base?
Conversation
(\w+) '([a-z0-9.-]+):([a-z0-9-]+):(\d+\.\d+(\.\d+)?)' to $1 group: '$2', name:'$3', version:'$4'
Conflicts: backend/molgenis-emx2-beacon-v2/build.gradle backend/molgenis-emx2-fairdatapoint/build.gradle backend/molgenis-emx2-graphgenome/build.gradle backend/molgenis-emx2-rdf/build.gradle backend/molgenis-emx2-run/build.gradle backend/molgenis-emx2-sql/build.gradle backend/molgenis-emx2/build.gradle
…hings don't break (due to incorrect linting suggestions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need confirmation that this works with renovate before I can approve this. I find this not really much cleaner that it was before. In practice we are building one big fat jar so moving the shared dependencies to the /backend/build.gradle is in my mind better option.
I checked with the Renovate CLI version (see initial PR message) to see if it spotted the
Source: https://docs.renovatebot.com/java/#gradle-file-support
Done (untested which I'll do later, but do let me know if this is indeed the preferred way compared to 1394ef5). |
Quality Gate passedIssues Measures |
What are the main changes you did:
Migrated the "dependencies for all subprojects" (except generic testing ones like junit) to their actual projects and filtered out the ones not needed per-module.LOG_LEVEL=debug renovate --platform=local > renovate.log
. As shown below it seems that Renovate understands the changes.master
PR
how to test:
LOG_LEVEL=debug renovate --platform=local > renovate.log
) should indicate it understands the changes that were made.todo: