Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (catalogue)menu options aren't consistent with the buttons available on network-of-networks page #4322

Closed
Tracked by #4147
EleanorHyde-UMCG opened this issue Oct 8, 2024 · 0 comments · Fixed by #4334
Closed
Tracked by #4147

fix (catalogue)menu options aren't consistent with the buttons available on network-of-networks page #4322

EleanorHyde-UMCG opened this issue Oct 8, 2024 · 0 comments · Fixed by #4334
Assignees
@connoratrug
Labels
bug Something isn't working ssr-catalogue

Comments

@EleanorHyde-UMCG
Copy link
Contributor

EleanorHyde-UMCG commented Oct 8, 2024 •
edited
Loading

What version of EMX2 are you using (see footer)
v11.16.2 (in acc)

Describe the bug
The menu options above a network of networks with all resource types are incorrect. The resource types in the network being tested are as follows:
cohort studies
data sources
databanks
networks
variables

but the menu options above are only as follows:
cohort studies
databanks
networks
variables
more (about / other catalogues / update data)

The menu options need to match the resource buttons available on the screen.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://data-catalogue-acc.molgeniscloud.org/testCatalogue/ssr-catalogue/testNetworkofNetworks
  2. See the buttons available and compare with the menu options above.

Expected behavior
I would expect the menu options to match the buttons available.

Screenshots
image

Desktop (please complete the following information):

  • OS: windows 10
  • Browser chrome
@EleanorHyde-UMCG EleanorHyde-UMCG mentioned this issue Oct 8, 2024
Open
33 tasks
@EleanorHyde-UMCG EleanorHyde-UMCG changed the title menu options aren't consistent with the butttons available on network-of-networks page fix (catalogue)menu options aren't consistent with the buttons available on network-of-networks page Oct 8, 2024
@EleanorHyde-UMCG EleanorHyde-UMCG added bug Something isn't working ssr-catalogue labels Oct 8, 2024
connoratrug added a commit that referenced this issue Oct 10, 2024
@connoratrug
fix: Catalogue menu
4ebe1e0 
Add typing the menu items data fetch
Fix usage of menu items data fetch ( use same filter as page)

Closes #4322
@connoratrug connoratrug self-assigned this Oct 10, 2024
@connoratrug connoratrug mentioned this issue Oct 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connoratrug connoratrug

Labels
bug Something isn't working ssr-catalogue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(catalogue): menu molgenis/molgenis-emx2
2 participants
@connoratrug @EleanorHyde-UMCG