Feat/list of networks #232

svituz · 2021-05-25T09:35:58Z

This PR adds the network view mode that displays the biobanks grouped by network and allows searching for networks.
The main changes are the following:

View mode specified in url (default biobankview)
Available filters are depends on the view mode
Network view:
3.1.it applies immediately the biobank_network and collection_network filters to get only biobanks and collections which are part of a network
3.2 for the collections, it filters the collections which are directly part of the network or part of a biobank which is part of the network
3.3 the network card has an embedded biobank explorer with the biobanks of the networks.
Biobank view: Changed the biobank_network and collection_network filters to reflect the same behaviour of the network view.

Checklist

molgenis-jenkins · 2021-05-25T09:38:18Z

⭐ PR Preview available on https://preview-bbmri-pr-232.dev.molgenis.org

codecov · 2021-05-25T09:38:52Z

Codecov Report

Merging #232 (ba5a0df) into master (0d86d14) will increase coverage by 3.9%.
The diff coverage is 95.3%.

@@           Coverage Diff            @@
##           master    #232     +/-   ##
========================================
+ Coverage    87.1%   91.1%   +3.9%     
========================================
  Files          35      37      +2     
  Lines         937    1089    +152     
  Branches      199     241     +42     
========================================
+ Hits          817     993    +176     
+ Misses        111      87     -24     
  Partials        9       9

Flag	Coverage Δ
unit	`91.1% <95.3%> (+3.9%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/ResultHeader.vue	`100.0% <ø> (ø)`
src/components/filters/ActiveFilterList.vue	`58.3% <ø> (+41.6%)`	⬆️
src/router/index.js	`100.0% <ø> (ø)`
src/store/state.js	`100.0% <ø> (ø)`
src/store/mutations.js	`85.6% <81.2%> (+5.0%)`	⬆️
src/store/getters.js	`86.1% <93.1%> (+5.0%)`	⬆️
src/components/BiobankExplorerContainer.vue	`84.2% <100.0%> (+1.4%)`	⬆️
src/components/cards/BiobankCardsContainer.vue	`100.0% <100.0%> (+18.7%)`	⬆️
src/components/cards/NetworkCard.vue	`100.0% <100.0%> (ø)`
src/components/cards/NetworkCardsContainer.vue	`100.0% <100.0%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d86d14...ba5a0df. Read the comment docs.

molgenis-jenkins · 2021-07-02T16:33:31Z

⭐ PR Preview available on https://preview-bbmri-pr-232.dev.molgenis.org

molgenis-jenkins · 2021-07-02T16:34:07Z

⭐ PR Preview available on https://preview-bbmri-pr-232.dev.molgenis.org

… and their collections

…nd network views

… displayed

…of a biobank of the network

… and grouping functions

When the biobank network filters is selected, it gets the biobanks in the network and the also all the collections in the found biobanks

…ight

… part of a network because of the bug, biobanks that are not part of a network but that have collections part of it, wasn't shown in the network tab. This commit fix it

…etwork before this fix, if a biobank wasn't part of a network but one of its collection was, all the collections of the biobank appeared in the network

… to version 4.6.0

molgenis-jenkins · 2021-09-09T10:55:07Z

⭐ PR Preview available on https://preview-bbmri-pr-232.dev.molgenis.org

molgenis-jenkins · 2021-09-09T13:14:26Z

⭐ PR Preview available on https://preview-bbmri-pr-232.dev.molgenis.org

jelmerveen · 2021-10-07T13:03:18Z

For this to be merged, it needs to be contained to the existing network view, or in a separate view.
It can not change existing routes, because of other parties using the app and the current routing system.

svituz added 26 commits September 7, 2021 16:26

feat: first implementation of list of networks. It shows the networks…

44a1533

… and their collections

feat: adds biobanks to network tab in network view mode

f7ba503

feat: adds viewmode state property to differentiate between biobank a…

688140c

…nd network views

fix: fix 'loading' writing in network view mode

9e23437

refactor: changes name of GetNetworkInfo function

827277c

fix: fix create bookmark: now it doesn't include filters that are not…

39cc223

… displayed

feat: network view now have biobank cards as children

6e4b4ee

feat: adds filters for common parameters for networks

295d7da

refactor(network view): refactor in filterDefinitions and ux style

87b4a52

test(network view): adds some tests and adapts others to new features

def2646

feat(network view): adds network result information in the result header

681f213

feat(network view): adds collections not directly in the network but …

c3ebab8

…of a biobank of the network

test(network view): adds tests for action GetNetworkInfo

e378749

test(network view): adds tests for BiobankExplorerContainer

b6e1d1e

test(network view): adds tests for BiobankCardsContainer

d21a774

test(network view): adds tests for NetworkCard, NetworkCardsContainer…

cf07a2f

… and grouping functions

test: adds tests for ActiveFilterList

b095c89

test: adds some tests for actions

ee26ee7

test: adds tests for getters

8646458

test: adds tests for mutations

0b63687

feat: changes the biobank network filters logic

bea369a

When the biobank network filters is selected, it gets the biobanks in the network and the also all the collections in the found biobanks

feat: changes network filter and biobank filter in rsql to be in or

14b7351

test: adds test for arrayEqual

bbb4c26

feat: adds search by name for networks

3c288d6

test: changes tests GetBiobankIdsInNetwork and GetNetworkIds

8b444c7

refactor: removes unused file

4912aa1

svituz added 7 commits September 7, 2021 18:04

Changes network card icon and adds plus button to open the card

17fc8e1

feat(network-view): changes collapse icon for network card to caret-r…

23e5348

…ight

fix(network-view): bug that didn't show the biobanks with collections…

8836fde

… part of a network because of the bug, biobanks that are not part of a network but that have collections part of it, wasn't shown in the network tab. This commit fix it

fix(network-view): fix a bug that included all the collections to a n…

9aa9af5

…etwork before this fix, if a biobank wasn't part of a network but one of its collection was, all the collections of the biobank appeared in the network

feat(network-view): some minor changes

96bdd4c

feat: restores old beahviour that opened the card of the first biobank

d783548

refactor(networkview): Changed implementation after rebase and update…

ba5a0df

… to version 4.6.0

svituz force-pushed the feat/list-of-networks branch from 64d703e to ba5a0df Compare September 9, 2021 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/list of networks #232

Feat/list of networks #232

svituz commented May 25, 2021

molgenis-jenkins commented May 25, 2021

codecov bot commented May 25, 2021 •

edited

Loading

molgenis-jenkins commented Jul 2, 2021

molgenis-jenkins commented Jul 2, 2021

molgenis-jenkins commented Sep 9, 2021

molgenis-jenkins commented Sep 9, 2021

jelmerveen commented Oct 7, 2021

Feat/list of networks #232

Are you sure you want to change the base?

Feat/list of networks #232

Conversation

svituz commented May 25, 2021

Checklist

molgenis-jenkins commented May 25, 2021

codecov bot commented May 25, 2021 • edited Loading

Codecov Report

molgenis-jenkins commented Jul 2, 2021

molgenis-jenkins commented Jul 2, 2021

molgenis-jenkins commented Sep 9, 2021

molgenis-jenkins commented Sep 9, 2021

jelmerveen commented Oct 7, 2021

codecov bot commented May 25, 2021 •

edited

Loading