TS: Parameter values are optional when can't be inferred

[molefrog]

Partially addresses #229
Closes #214

• When route parameters can't be inferred at a compile time, they become optional now. Routes may contain optional segments (e.g. /:rest*) so some parameters could be undefined
• Parameter values are now readonly

[github-actions]

size-limit report 📦

Path	Size
index.js	1.11 KB (0%)
use-location.js	159 B (0%)

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3349dee) compared to base (9d9ad91).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          255       255           
  Branches        50        50           
=========================================
  Hits           255       255           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[molefrog]

Hey @HansBrende, I hope this is still relevant. Once again, sorry for my late reply. I've updated type definitions based on your suggestions, do you mind taking a look?

Thanks!

[HansBrende]

@molefrog thanks! I've taken a look and it appears to be working as expected now. (Note however that I've only tested the typescript 4.1 and standard React flavors, I have not tested on Preact or out-of-date typescript versions).

Also note my comment describing how the second half of the issue I raised is fixed in the React 18 typings, but still present before React 18.

Side note: since you now seem to be back in business, I have a PR open which I've been waiting for some kind of resolution for (would love to replace the hacks in my current codebase with this simple fix) if you'd be so kind as to take a look: #231

[molefrog]

@molefrog thanks! I've taken a look and it appears to be working as expected now. (Note however that I've only tested the typescript 4.1 and standard React flavors, I have not tested on Preact or out-of-date typescript versions).

Also note my comment describing how the second half of the issue I raised is fixed in the React 18 typings, but still present before React 18.

Thank you for the review.

The second half of the issue is to be addresses in the next PR, I've checked it and it is a valid point.

Side note: since you now seem to be back in business, I have a PR open which I've been waiting for some kind of resolution for (would love to replace the hacks in my current codebase with this simple fix) if you'd be so kind as to take a look: #231

Yep, in my to-do list.