feat: basepath should be case-insensitive #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molefrog
requested changes
Oct 21, 2020
use-location.js
Outdated
| @@ -20,7 +20,7 @@ export default ({ base = "" } = {}) => { | |||
| // unfortunately, we can't rely on `path` value here, since it can be stale, | |||
| // that's why we store the last pathname in a ref. | |||
| const checkForUpdates = () => { | |||
| const pathname = currentPathname(base); | |||
There was a problem hiding this comment.
Can we get the old name back, please 🙏
currentPathname is just more readable
There was a problem hiding this comment.
Of course, I just want to reduce the number of bytes
|
@molefrog done. please review again. |
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 7 7
Lines 200 200
Branches 35 35
=======================================
Hits 199 199
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello, @molefrog
The wouter
matcheris case-insensitive by default, so thebasepathshould be case-insensitive default too ?keep
pathnameandbasepathwith the same default behavior, so we can reducing user confusion.Of course, we can also provide a
sensitiveparameter, but it should be applied tomatcherandbasepathat the same time, otherwise, we will ignore case by default.Do you have any suggestions？