Support nested objects in query params #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to expose a
moleculer-db
service through the API gateway I noticed there is no way to pass thequery
param to the serviceslist
action (doc). The service expects thequery
param to be of typeobject
but nested objects are not supported by node'squerystring
module (see nodejs/node-v0.x-archive#1665).This PR replaces
querystring
withqs
, which supports nested objects.Example Request:
GET /users/list?query[name]=Peter
Before (using
querystring
module):params: { "query[name]": "Peter" }
After (using
qs
module):params: { "query": { "name": "Peter" }}
What do you think?