fix: #298: register on close and error event on response #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-bertoncelli
changed the title
|
Great, thanks! |
|
@icebob maybe the call should be always resolved instead of rejected since if rejected moleculer tries to write the headers, but since the response stream has already started the headers are surely already been written. Which approach do you prefer? |
|
Can we check that the response stream is started? And in this case, we block the header sending. |
|
@icebob how can we do that? By resolving if (BTW @michelevincenzi is my colleague, we're working together on this) |
|
we can reject, but check the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #298.
Added handlers to handle
errorandcloseevents on response and resolve/reject respectively the context caller.