Add 'today' parameter to .parse method #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs mojombo#295 This one allows Chronic.parse method to receive `today: true` param alongside a string to parse to allow parsing ambiguous week days by name. E.g.: Time.now #=> Sun Aug 27 23:18:25 PDT 2006 Chronic.parse('sunday') #=> Sun Sep 03 12:00:00 PDT 2006 Chronic.parse('sunday', today: true) #=> Sun Aug 27 12:00:00 PDT 2006
novikserg
force-pushed
the
parse_today_by_day_name_optionally
branch
from
49a52e2
to
5befd51
Compare
|
yeah I think this can be used, what do you @leejarvis think? also might as well merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #295
This one allows
Chronic.parsemethod to receivetoday: trueparam alongside a string to parse to allow parsing ambiguous week days by name. For example:Somewhat a quick workaround for now since new version is going to change it all anyway.