Respect the processParent setting by introducing a new base class #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamvoss
force-pushed
the
respect-update-parent-setting
branch
2 times, most recently
from
5efe092
to
ab3ea44
Compare
adamvoss
force-pushed
the
respect-update-parent-setting
branch
from
ab3ea44
to
6b297e5
Compare
|
I think i'm responsible for some of the other "parentProcessing" Mojo's. One thing i noticed recently, is that if you try to "processParent" but you have no snapshot dependencies, it skips the whole operation. Something i'll have to address, and something to double check works for your change as well :) |
|
Is there any reason why this fix is not merged yet? Will this change also fix my issue regarding updating versions (versions:update-properties), in a property when the property is defined in the parent POM, of a project? My project structure:
Command which doesn't update the parent pom: There is a higher version (3.1.26) and it does work if a move the property to the poms of moduleA and moduleB (but I don't want to duplicate these versions..) @DiJu519 any updates regarding this issue? |
|
This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 9, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 10, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 10, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 11, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 11, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 11, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 11, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 11, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 13, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Nov 16, 2022
Also: - added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo - enhanced documentation on UseReleasesMojo#allowRangeMatching - streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos - added unit tests and integration tests - some refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the
processParentsetting by introducing a new base class.Fixes #288 (
UseNextReleasesMojo). Also, fixes an analogous bug inForceReleasesMojo,UseDepVersionMojo,UseNextReleasesMojo,UseNextSnapshotsMojo, andUseNextVersionsMojoThe other existing Mojos that were not modified have their own parent-handling functionality except for
CompareDependenciesMojoandUpdatePropertiesMojowhere the setting still has no effect.