-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencyExcludes/dependencyIncludes should filter on the output dependency versions #921
Comments
Looks like I'm confused. It's already implemented: https://www.mojohaus.org/versions/versions-maven-plugin/display-dependency-updates-mojo.html#ignoredVersions |
Tentatively reopening: the semantics of the feature is unclear and even misleading to most users and it would make much more sense to treat version (and, by extension, the whole filter) as that of the target dependency. To be decided where to go from here:
@slawekjaranowski any thoughts? Or maybe: make the documentation more clean on it and provide examples how to use it, and how to use the |
…udes/dependencyExcludes with a faq section and an example
Made a PR with some documentation changes. |
…udes/dependencyExcludes with a faq section and an example
…udes/dependencyExcludes with a faq section and an example
…udes/dependencyExcludes with a faq section and an example
…endencyExcludes with a faq section and an example
…or restrictionForIgnoreScope
…or restrictionForIgnoreScope
It looks like the options filter on the input dependencies, i.e. dependencies that are already present in the POM. I think they should actually filter on output dependencies (regarding versions).
Question is whether this change should be applied directly or using a new feature toggle (to avoid backwards incompatibilities). Although I expect the current behaviour is not intuitive and direct change would not bring about much harm.
The text was updated successfully, but these errors were encountered: