Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the Versions Plugin to find rules via the classpath #193

Closed
obfischer opened this issue Aug 5, 2017 · 6 comments
Closed

Enable the Versions Plugin to find rules via the classpath #193

obfischer opened this issue Aug 5, 2017 · 6 comments

Comments

@obfischer
Copy link
Contributor

It could be usefull to search for rules also on the classpath to ease the use of a single rules set in multiple projects. This would allow a user of the Maven Versions Plugin to distribute its rules set inside a Jar and to integrate in a Maven project by using the standard Maven dependency mechanism.
@obfischer
Copy link
Contributor Author

I will provide an PR for this issue.

@khmarbaise
Copy link
Member

That would be great...

@obfischer
Copy link
Contributor Author

I am working on a PR including tests and additions to the documentation.

obfischer added a commit to obfischer/fork-of-versions-maven-plugin that referenced this issue Aug 14, 2017
@obfischer
Added support for loading rules from the classpath. See mojohaus#193 …
28fae83 
…fore more details.
obfischer added a commit to obfischer/fork-of-versions-maven-plugin that referenced this issue Aug 14, 2017
@obfischer
Mentioned support for loading the rules file from the classpath in Ja…
f7dc2c8 
…vaDoc. See mojohaus#193 for more.
obfischer added a commit to obfischer/fork-of-versions-maven-plugin that referenced this issue Aug 14, 2017
@obfischer
Update the documentation with an example how to load a rules files fr…
7e06893 
…om the classpath. See mojohaus#193 for more.
@khmarbaise
Copy link
Member

Can you please squash the commits....

@obfischer
Copy link
Contributor Author

Yes, will do that before I will create an PR.

obfischer added a commit to obfischer/fork-of-versions-maven-plugin that referenced this issue Aug 16, 2017
@obfischer
Fixed mojohaus#193
c46539b 
 o Added support for loading rules from the classpath.
 o Mentioned support for loading the rules file from the classpath in JavaDoc.
 o Update the documentation with an example how to load a rules files from the classpath.
@obfischer
Copy link
Contributor Author

I created an PR for this issue.

khmarbaise added a commit that referenced this issue Aug 21, 2017
@khmarbaise
Merge pull request #199 from obfischer/gh-issue-193-take-rules-from-c…
be04640 
…lasspath

Fixed #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khmarbaise @obfischer