Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too aggressive logging of Assuming allowMajorUpdates false because allowMinorUpdates is false #1131

Closed
gmshake opened this issue Aug 20, 2024 · 0 comments · Fixed by #1132
Closed
Milestone

Comments

@gmshake
Copy link
Contributor

gmshake commented Aug 20, 2024

I have a project utilize the goal display-dependency-updates to check minor and incremental dependency updates. The config has explicitly set allowMajorUpdates to false, but on running
the goal the plugin still emit lots of Assuming allowMajorUpdates false because allowMinorUpdates is false.

[INFO] --- versions:2.17.1:display-dependency-updates (default) @ foo ---
[INFO] Assuming allowMajorUpdates false because allowMinorUpdates is false.
[INFO] Assuming allowMajorUpdates false because allowMinorUpdates is false.
[INFO] Assuming allowMajorUpdates false because allowMinorUpdates is false.
[INFO] Assuming allowMajorUpdates false because allowMinorUpdates is false.
[INFO] Assuming allowMajorUpdates false because allowMinorUpdates is false.
[INFO] Assuming allowMajorUpdates false because allowMinorUpdates is false.
[INFO] Assuming allowMajorUpdates false because allowMinorUpdates is false.
...

I think those logging can be omitted if user set allowMajorUpdates to false explicitly.

gmshake added a commit to gmshake/versions-maven-plugin that referenced this issue Aug 20, 2024
…wMinorUpdates and allowIncrementalUpdates are in valid combination
@slawekjaranowski slawekjaranowski added this to the next-release milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants