Add tidy.skip parameter. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisl
added a commit
that referenced
this pull request
Nov 8, 2016
iText-CI
pushed a commit
to itext/itext-java
that referenced
this pull request
Jan 29, 2020
Changes in this commit: * Use Maven option "--no-transfer-progress" - requires Maven >=3.6.1. * Clean Workspace: combining "mvn clean" and "mvn dependency:purge-local" gives a 5-15% performance improvement. * Compile: "compile" is already implied by "package". * Compile: tests are skipped, so no need to run test-compile (implied by verify in "Run Tests" stage). * Compile: Javadoc failOnError is already false in pom.xml, not needed in Jenkinsfile. * Run Tests: the main classes are already compiled, so don't need to be compiled again. Because we can't assume this to be the case on a developer machine, this is done in the Jenkinsfile, not in the pom.xml. * Run Tests: Javadocs and sources not needed, skipped in pom.xml (profiles "test" and "qa"). * Run Tests: skip tidy and sortpom in "test" and "qa" profiles. * Static Code Analysis before Run Tests. * Remove duplicates (spotbugs and dependency-check) from Run Tests. * Artifactory Deploy: Artifactory Jenkins plugin takes artifacts (pom/jar/war/...) from the .m2 directory, not from the target directory. This implies that the "install" phase of the Maven Lifecycle must run. See https://www.jfrog.com/jira/browse/HAP-957 - reply by Yahav Itzhak (JFrog): "Aggregating artifacts and deploying them in "install" is a legacy behavior and it's running correctly for years. Aggregating pom files in "package" goal is not trivial and it demands weeks of development and tests. As a workaround, one can use "clean install package". The disadvantage of this workaround is the population of the `.m2` cache." * Profile "artifactory" in pom.xml: disables all the plugins that already ran in previous stages. * Branch artifacts are now taken from the correct target directory. * "qa" profile in pom.xml: main and test classes are always assumed to be compiled in previous stages, so these can be skipped. * Move Spotbugs and OWASP Dependency Check to QA profile. * Version bump of tidy-maven-plugin to be able to skip it, see mojohaus/tidy-maven-plugin#12 * Update OWASP dependency check. * Bump versions of QA plugins. * Replace Findbugs with Spotbugs. * Ignore missing classes for japicmp. * Increase retries to 2. * Remove redundant artifact archiving stage. The Pipeline Maven Plugin already does this transparantly, see https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-ReportPublishers * Publish XML reports of static code analysis tools to Jenkins. QA-7892 QA-8167
iText-CI
added a commit
to itext/itext-dotnet
that referenced
this pull request
Jan 29, 2020
Fix deployment to Artifactory Changes in this commit: * Use Maven option \"--no-transfer-progress\" - requires Maven >=3.6.1. * Clean Workspace: combining \"mvn clean\" and \"mvn dependency:purge-local\" gives a 5-15% performance improvement. * Compile: \"compile\" is already implied by \"package\". * Compile: tests are skipped, so no need to run test-compile (implied by verify in \"Run Tests\" stage). * Compile: Javadoc failOnError is already false in pom.xml, not needed in Jenkinsfile. * Run Tests: the main classes are already compiled, so don't need to be compiled again. Because we can't assume this to be the case on a developer machine, this is done in the Jenkinsfile, not in the pom.xml. * Run Tests: Javadocs and sources not needed, skipped in pom.xml (profiles \"test\" and \"qa\"). * Run Tests: skip tidy and sortpom in \"test\" and \"qa\" profiles. * Static Code Analysis before Run Tests. * Remove duplicates (spotbugs and dependency-check) from Run Tests. * Artifactory Deploy: Artifactory Jenkins plugin takes artifacts (pom/jar/war/...) from the .m2 directory, not from the target directory. This implies that the \"install\" phase of the Maven Lifecycle must run. See https://www.jfrog.com/jira/browse/HAP-957 - reply by Yahav Itzhak (JFrog): \"Aggregating artifacts and deploying them in \"install\" is a legacy behavior and it's running correctly for years. Aggregating pom files in \"package\" goal is not trivial and it demands weeks of development and tests. As a workaround, one can use \"clean install package\". The disadvantage of this workaround is the population of the `.m2` cache.\" * Profile \"artifactory\" in pom.xml: disables all the plugins that already ran in previous stages. * Branch artifacts are now taken from the correct target directory. * \"qa\" profile in pom.xml: main and test classes are always assumed to be compiled in previous stages, so these can be skipped. * Move Spotbugs and OWASP Dependency Check to QA profile. * Version bump of tidy-maven-plugin to be able to skip it, see mojohaus/tidy-maven-plugin#12 * Update OWASP dependency check. * Bump versions of QA plugins. * Replace Findbugs with Spotbugs. * Ignore missing classes for japicmp. * Increase retries to 2. * Remove redundant artifact archiving stage. The Pipeline Maven Plugin already does this transparantly, see https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-ReportPublishers * Publish XML reports of static code analysis tools to Jenkins. QA-7892 QA-8167 Autoported commit. Original commit hash: [af43d5ccc] Manual files: Jenkinsfile pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #10 that bypasses execution completely for both goals.