Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mockito-core dependency to fix test errors #60

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

kohlschuetter
Copy link
Contributor

With mockito 3.12.4, you may get weird errors when running junit code (File.exists throwing NullPointerException, etc.)

Update dependency version to the latest available, 5.4.0.

With mockito 3.12.4, you may get weird errors when running junit code
(File.exists throwing NullPointerException, etc.)

Update dependency version to the latest available, 5.4.0.
@slachiewicz
Copy link
Member

Project targets Java 8 and Mocito 5 requires Java 11

@kohlschuetter
Copy link
Contributor Author

@slachiewicz Thanks for your prompt reply!

mockito-core 4.11.0 (which is supposed to be compatible with Java 8) unfortunately does not fix the issue.
You can see from the number of failed builds by dependabot that fixing this is somewhat important.

Thankfully, since mockito-core is just a test-scope dependency, the final plugin should still work with Java 8, it's only that building requires Java 11.

As you already bumped the major version number to 3, I hope this is an acceptable solution.

Thoughts?

This is no longer possible due to the updated mockito-core dependency.

However, running the plugin with Java 8 is still possible.
@slachiewicz slachiewicz merged commit 9a632cb into mojohaus:master Jul 16, 2023
@slachiewicz slachiewicz added the dependencies Pull requests that update a dependency file label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants