Add support for mocking timetstamped snapshots #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjatkins
commented
Apr 15, 2019
rjatkins
commented
- Ensure any poms loaded from the mrm repo directory that have timestamps for their versions are registered as snapshots, so that we can easily load them later
- Add factory methods to Artifact to make it easier to build new Artifacts from an existing Artifact object definition
- Make Artifact responsible for the parsing logic of timestamped versions, to avoid copying it into MockArtifactStore to use during its registration phase
- Fix typos in FileSystemArtifactStore and ArtifactStoreFileSystem javadoc
* Ensure any poms loaded from the mrm repo directory that have timestamps for their versions are registered as snapshots, so that we can easily load them later * Add factory methods to Artifact to make it easier to build new Artifacts from an existing Artifact object definition * Make Artifact responsible for the parsing logic of timestamped versions, to avoid copying it into MockArtifactStore to use during its registration phase * Fix typos in FileSystemArtifactStore and ArtifactStoreFileSystem javadoc
* Collect the timestamp and build number directly from the filename on disk, rather than relying on these to be embedded in the artifact version element. This matches standard maven repo behaviour.
|
Interesting, although I would have expected that timestamped versions would already be supported. I'm missing some kind of test that demonstrates this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.