[#391] Cope with Thread::stop being unavailable in JDK 20+ #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JDK 20+, the long deprecated Thread.stop() (since JDK 1.2) has been removed and will throw an UnsupportedOperationException. This will be handled gracefully when using option 'stopUnresponsiveDaemonThreads', yielding a log warning "Thread.stop() is unavailable in this JRE version, cannot force-stop any threads" once and not trying to stop any further threads during the same execution. Tests and documentation have been adjusted accordingly. Closes mojohaus#391.
Because mojohaus#391 introduces special handling of the fact that in JDK 20+ there is no more Thread::stop, we should also run the tests on JDK 21.
|
@slawekjaranowski, this is ready for review. |
|
Thanks. I think we also should deprecate options |
slawekjaranowski
approved these changes
Nov 11, 2023
slawekjaranowski
approved these changes
Nov 11, 2023
Despite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JDK 20+, the long deprecated
Thread.stop()(since JDK 1.2) has been removed and will throw anUnsupportedOperationException. This will be handled gracefully when using optionstopUnresponsiveDaemonThreads, yielding a log warning "Thread.stop() is unavailable in this JRE version, cannot force-stop any threads" once and not trying to stop any further threads during the same execution.Tests and documentation have been adjusted accordingly.
Closes #391.