-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added bulk sdk tests and onboarding #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updates for rules files and additional collections * updated request with env vars * Updated happy path to remove to fspId * Updated test cases * Added TC for NDC limit error * renamed variables to use TTKSIM instead of SIM * removed url variable * Updates to parameterize parties error test cases * Updates with latest async approach * updates for async feature * Updates for bad request test case * Updated parties errors with async callbacks * Updates for async test mode * Updates for quotes error cases * Updates for transfers -ve test case to use async * Updated TC based on the updated rule * Updates to TC2 of transfers * updated TC2 * Updates for TC4 * Added env file for onboarding * added env file * Updated TC5 with async * Updated TC for parties error cases * Updated test for async * Updated BQ-10 * Updates to TC-4 * Split the TCs into failures and pass * move failures to a different folder * changed folder and file names * Updated test cases to reflect correct status * updates to tests * updated TC-4 * renamed folders and file names * updates * fix: aligned with rules file in mvp bulk branch * fix: changed example env files Co-authored-by: Vijay <[email protected]>
* Updates to parties test cases * updates to assertions * Added a new test case * Updates for TC-BQ9 * updates for BQ-9 * refactoring of test cases
chore: changed the folders for sdk tests
* Status updated on BP2 * State update on BP6 * fix: fixed tests and changed some values in sdk bulk tests Co-authored-by: Sridevi Miriyala <[email protected]>
vijayg10
previously approved these changes
Nov 14, 2022
sri-miriyala
previously approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mdebarros
dismissed stale reviews from sri-miriyala and vijayg10
via
November 14, 2022 15:30
9b47b92
…es into mvp/bulk-sdk
16 tasks
sri-miriyala
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates for rules files and additional collections
updated request with env vars
Updated happy path to remove to fspId
Updated test cases
Added TC for NDC limit error
renamed variables to use TTKSIM instead of SIM
removed url variable
Updates to parameterize parties error test cases
Updates with latest async approach
updates for async feature
Updates for bad request test case
Updated parties errors with async callbacks
Updates for async test mode
Updates for quotes error cases
Updates for transfers -ve test case to use async
Updated TC based on the updated rule
Updates to TC2 of transfers
updated TC2
Updates for TC4
Added env file for onboarding
added env file
Updated TC5 with async
Updated TC for parties error cases
Updated test for async
Updated BQ-10
Updates to TC-4
Split the TCs into failures and pass
move failures to a different folder
changed folder and file names
Updated test cases to reflect correct status
updates to tests
updated TC-4
renamed folders and file names
updates
fix: aligned with rules file in mvp bulk branch
fix: changed example env files
Co-authored-by: Vijay [email protected]