-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bulk negative scenario tests for invalid and inactive fspId #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kleyow
commented
Jul 27, 2022
•
edited
Loading
edited
kleyow
force-pushed
the
feat/bulk-negative-scenarios
branch
from
July 28, 2022 21:46
5ff8cb4
to
fb2fbc2
Compare
kleyow
changed the title
feat: add bulk negative scenario tests
feat: add bulk negative scenario tests for invalid fspId
Jul 28, 2022
collections/hub/other_tests/bulk_transfers/bulk-invalid-dfsp-name-header-and-body.json
Outdated
Show resolved
Hide resolved
collections/hub/other_tests/bulk_transfers/bulk-invalid-dfsp-name-header-and-body.json
Outdated
Show resolved
Hide resolved
collections/hub/other_tests/bulk_transfers/bulk-invalid-dfsp-name-header-and-body.json
Outdated
Show resolved
Hide resolved
Thanks Kevin, good to have this PR.. In general, we need to use Payer FSP / Payee FSP instead of Payer and Payee to avoid any ambiguity.. |
…ame-header-and-body.json Co-authored-by: Sam <[email protected]>
…ame-header-and-body.json Co-authored-by: Sam <[email protected]>
…ame-header-and-body.json Co-authored-by: Sam <[email protected]>
@elnyry-sam-k done. |
|
kleyow
changed the title
feat: add bulk negative scenario tests for invalid fspId
feat: add bulk negative scenario tests for invalid and inactive fspId
Aug 1, 2022
elnyry-sam-k
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.