Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mojaloop/#2845): change noresponse fsp to ttk and version spec #119

Merged
merged 10 commits into from
Apr 6, 2023
Merged

test(mojaloop/#2845): change noresponse fsp to ttk and version spec #119

merged 10 commits into from
Apr 6, 2023

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Mar 30, 2023 •
edited
Loading

test(mojaloop/#2845): change noresponse fsp to ttk and version spec - mojaloop/project#2845

  • Change noresponsepayeefsp callbacks to point to ml-testing-toolkit
  • Add ml-testing-toolkit rules for versioning

Tested with

helm --namespace moja4 upgrade moja4 ./mojaloop -f /home/kleyow/mojaloop/deploy-config/mojaloop/test.mojaloop.live/values-moja4-test-mojaloop-harness-v15.0.0.feat2845.yaml \
  --set ml-ttk-test-setup.tests.enabled=true \
  --set ml-ttk-test-val-gp.tests.enabled=true \
  --set ml-ttk-test-val-bulk.tests.enabled=true \
  --set ml-ttk-test-setup-tp.tests.enabled=false \
  --set ml-ttk-test-val-tp.tests.enabled=false \
  --set account-lookup-service.account-lookup-service.config.featureEnableExtendedPartyIdType=false \
  --set account-lookup-service.account-lookup-service-admin.config.featureEnableExtendedPartyIdType=false \
  --set thirdparty.enabled=false \
  --set mojaloop-bulk.enabled=true \
  --set ml-ttk-test-val-bulk.tests.enabled=true
helm -n moja4 upgrade backend ./example-mojaloop-backend --install -f /home/kleyow/mojaloop/deploy-config/mojaloop/test.mojaloop.live/values-moja4-test-mojaloop-backend-v15.0.0.yaml

image

@kleyow kleyow mentioned this pull request Mar 31, 2023
Closed
15 tasks
@kleyow kleyow marked this pull request as ready for review April 4, 2023 03:58
mdebarros
mdebarros requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per review discussion...

Please re-look at the "delay"'s, as we should no longer require them except for the "timeout" use-cases.

And also make sure to remove any legacy "WS" waits.

mdebarros
mdebarros requested changes Apr 6, 2023
View reviewed changes
...ons/hub/golden_path/feature_tests/transfer_negative_scenarios/payee_invalid_fulfillment.json
},
{
"id": 3,
"description": "Callback Validate Protected Headers",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we need to add a story to add tests specifically for validating JWS, protected headers, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe other tests cover jws and protected headers. If you think these need it as well, I can make the story.

...tions/hub/golden_path/feature_tests/transfer_negative_scenarios/payee_invalid_timestamp.json
},
{
"id": 4,
"description": "Send Quote - Response",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know its ok to send the Quote Response here?

I don't see any await inboundEvent listener in the POST /Quotes to determine it was received by the NORESPONSE_SIMPAYEE_NAME.

Otherwise we may have a race condition with the PUT /Quotes request below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Added listener to POST /quotes, here and throughout.

collections/hub/golden_path/feature_tests/duplicate_handling/transfers/fulfill_commit.json Show resolved Hide resolved
collections/hub/golden_path/feature_tests/duplicate_handling/transfers/fulfill_commit.json Outdated Show resolved Hide resolved
collections/hub/golden_path/feature_tests/duplicate_handling/transfers/fulfill_commit.json Show resolved Hide resolved
collections/hub/golden_path/feature_tests/duplicate_handling/transfers/fulfill_commit.json Outdated Show resolved Hide resolved
collections/hub/golden_path/feature_tests/duplicate_handling/transfers/fulfill_reject.json Show resolved Hide resolved
collections/hub/golden_path/feature_tests/duplicate_handling/transfers/fulfill_reject.json Show resolved Hide resolved
collections/hub/golden_path/feature_tests/transfer_negative_scenarios/fulfil-reserved-v1.0.json Show resolved Hide resolved
@kleyow
Copy link
Contributor Author

kleyow commented Apr 6, 2023

Follow up story mojaloop/project#3275

mdebarros
mdebarros approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kleyow kleyow merged commit e48ae33 into master Apr 6, 2023
@kleyow kleyow deleted the test/#2845-no-response branch April 6, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleyow @mdebarros