chore(mojaloop/#3909): update func test harness and add fx sdk tests #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
requested review from
mdebarros,
elnyry-sam-k and
vijayg10
as code owners
kleyow
changed the title
kleyow
changed the title
vijayg10
reviewed
Jun 26, 2024
Comment on lines
+81
to
+86
| { | ||
| "type": "fspiop", | ||
| "version": "2.0", | ||
| "folderPath": "fspiop_2.0", | ||
| "asynchronous": true | ||
| }, |
| @@ -77,6 +77,25 @@ | |||
| "hostnames": [], | |||
| "prefix": "/sdk-out", | |||
| "asynchronous": true | |||
| }, | |||
There was a problem hiding this comment.
Can we remove these apis mojaloop_simulator_inbound and scheme_adapter_outbound as you added another version of them?
...nc/config/ttk-ttkfxp/spec_files/api_definitions/mojaloop_simulator_sim_1.4/response_map.json
Outdated
Show resolved
Hide resolved
...ttkfxp/spec_files/api_definitions/mojaloop_sdk_outbound_scheme_adapter_1.0/response_map.json
Outdated
Show resolved
Hide resolved
...xp/spec_files/api_definitions/fspiop_2.0/trigger_templates/transaction_request_followup.json
Outdated
Show resolved
Hide resolved
test/func/config/ttk-hub/spec_files/api_definitions/payment_manager_1.4/api_spec.yaml
Outdated
Show resolved
Hide resolved
| @@ -309,7 +309,7 @@ paths: | |||
|
|
|||
There was a problem hiding this comment.
I think we don't need this folder.
| @@ -526,7 +526,7 @@ paths: | |||
| $ref: "#/components/responses/503" | |||
There was a problem hiding this comment.
I think we don't need this folder.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(mojaloop/#3909): update func test harness and add fx sdk tests