Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/#2811): sdk-scheme-adapter sending incorrect transferState on a PUT transfers Callback #331

Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f2ece2e
fix(mojaloop/#2811): sdk-scheme-adapter sending incorrect transferSta…
mdebarros Jul 7, 2022
809598a
chore: fixed audit-resolve issues
mdebarros Jul 7, 2022
9a7b0d8
chore: aligned ci config to standards
mdebarros Jul 7, 2022
0487acc
chore: aligned ci config to standards
mdebarros Jul 7, 2022
4e8cf35
chore: test unit test fixes
mdebarros Jul 7, 2022
76376b5
chore: test unit test fixes
mdebarros Jul 7, 2022
4389489
chore(snapshot): 17.0.2-snapshot.0
mdebarros Jul 7, 2022
acae6fa
chore: updated npm-audit-resolve to latest version
mdebarros Jul 7, 2022
8472e19
chore: fixes for ci config
mdebarros Jul 7, 2022
9fe2aa0
chore(snapshot): 17.0.2-snapshot.1
mdebarros Jul 7, 2022
7db3bf0
chore(snapshot): 17.0.2-snapshot.2
mdebarros Jul 7, 2022
cb91333
chore: fixes for ci config
mdebarros Jul 7, 2022
cc7d2bd
chore(snapshot): 17.0.2-snapshot.3
mdebarros Jul 7, 2022
ca892fc
chore: fixes for ci config
mdebarros Jul 7, 2022
1351ba2
chore(snapshot): 17.0.2-snapshot.4
mdebarros Jul 7, 2022
4dfb027
chore: updat Dockerfile to add the ml-user
mdebarros Jul 7, 2022
855d3fe
chore(snapshot): 17.0.2-snapshot.5
mdebarros Jul 7, 2022
e270a2a
chore: update depenendencies
mdebarros Jul 7, 2022
35cdf94
chore(snapshot): 17.0.2-snapshot.6
mdebarros Jul 7, 2022
b50fd46
chore: updated dockerfile to use /opt/app folder to align to ml stand…
mdebarros Jul 7, 2022
d006c79
chore(snapshot): 17.0.2-snapshot.7
mdebarros Jul 7, 2022
b2da0fa
chore: fixes for docker-compose and integration.env
mdebarros Jul 7, 2022
45ada92
chore(snapshot): 17.0.2-snapshot.8
mdebarros Jul 7, 2022
d982ee3
chore: minor integration.env cleanup
mdebarros Jul 7, 2022
6ecdca4
chore(snapshot): 17.0.2-snapshot.9
mdebarros Jul 7, 2022
5e9f160
chore: fixed audits
mdebarros Jul 7, 2022
889d693
chore(snapshot): 17.0.2-snapshot.10
mdebarros Jul 7, 2022
a4a35da
removed commented out command from docker-compose
mdebarros Jul 7, 2022
155f4a3
chore(snapshot): 17.0.2-snapshot.11
mdebarros Jul 7, 2022
8efe1ed
fix(mojaloop/#2816): SDK-Scheme-Adapter is missing bulkTransferState …
mdebarros Jul 8, 2022
5764d23
chore(snapshot): 17.0.2-snapshot.12
mdebarros Jul 8, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
631 changes: 456 additions & 175 deletions .circleci/config.yml

Large diffs are not rendered by default.

20 changes: 18 additions & 2 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,18 @@
*node_modules*
*junit.xml*
deploy/
coverage/
node_modules/
.dockerignore
.editorconfig
.git/
.gitignore
.istanbul.yml
circle.yml
docker-compose.circle.yml
docker-compose.dev.yml
docker-compose.functional.yml
docker-compose.yml
Dockerfile
LICENSE
README.md
sonar-project.properties
.devspace/
17 changes: 12 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,20 @@ RUN apk add --no-cache git python3 build-base

EXPOSE 3000

WORKDIR /src
WORKDIR /opt/app

# This is super-ugly, but it means we don't have to re-run npm install every time any of the source
# files change- only when any dependencies change- which is a superior developer experience when
# relying on docker-compose.
COPY ./package.json .
COPY ./package-lock.json .
RUN npm ci --only=production

COPY src /opt/app/src

FROM node:16.15.0-alpine
WORKDIR /opt/app


ARG BUILD_DATE
ARG VCS_URL
Expand All @@ -28,8 +33,10 @@ LABEL org.label-schema.vcs-ref=$VCS_REF
LABEL org.label-schema.url="https://mojaloop.io/"
LABEL org.label-schema.version=$VERSION

COPY --from=builder /src/ /src
COPY ./src ./src
COPY ./secrets /
# Create a non-root user: ml-user
RUN adduser -D ml-user
USER ml-user

COPY --chown=ml-user --from=builder /opt/app .

CMD ["node", "src/index.js"]
CMD ["npm", "run", "start"]
95 changes: 27 additions & 68 deletions audit-resolve.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,99 +2,58 @@
"decisions": {
"1075703|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs": {
"decision": "ignore",
"madeAt": 1656678986448
"madeAt": 1657188195403,
"expiresAt": 1659780190646
},
"1075704|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs": {
"decision": "ignore",
"madeAt": 1656678989848
"madeAt": 1657188196343,
"expiresAt": 1659780190646
},
"1070412|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>ejs": {
"1080944|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>moment": {
"decision": "ignore",
"madeAt": 1656679958470
"madeAt": 1657188197274,
"expiresAt": 1659780190646
},
"1070412|ejs": {
"decision": "ignore",
"madeAt": 1656679958471
},
"1070030|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>ejs>markdown-it": {
"1070030|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>moment>shins>markdown-it": {
"decision": "ignore",
"madeAt": 1656679961621
"madeAt": 1657188198190,
"expiresAt": 1659780190646
},
"1070030|widdershins>markdown-it": {
"decision": "ignore",
"madeAt": 1656681873020
"madeAt": 1657188198190,
"expiresAt": 1659780190646
},
"1068155|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>ejs>markdown-it>sanitize-html": {
"1068155|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>moment>shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1656679964361
"madeAt": 1657188199040,
"expiresAt": 1659780190646
},
"1070260|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>ejs>markdown-it>sanitize-html": {
"1070260|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>moment>shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1656679966871
"madeAt": 1657188199954,
"expiresAt": 1659780190646
},
"1067553|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>ejs>markdown-it>sanitize-html>widdershins>swagger2openapi>better-ajv-errors>jsonpointer": {
"1070412|ejs": {
"decision": "ignore",
"madeAt": 1656679000803
"madeAt": 1657188200902,
"expiresAt": 1659780190646
},
"1067553|swagger2openapi>better-ajv-errors>jsonpointer": {
"decision": "ignore",
"madeAt": 1656679000803
},
"1067553|widdershins>markdown-it>swagger2openapi>better-ajv-errors>jsonpointer": {
"decision": "ignore",
"madeAt": 1656679000804
},
"1067946|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>ejs>markdown-it>sanitize-html>widdershins>swagger2openapi>better-ajv-errors>jsonpointer>oas-validator>ajv": {
"decision": "ignore",
"madeAt": 1656679005322
"madeAt": 1657188201786,
"expiresAt": 1659780190646
},
"1067946|swagger2openapi>better-ajv-errors>jsonpointer>oas-validator>ajv": {
"decision": "ignore",
"madeAt": 1656679005322
},
"1067946|widdershins>markdown-it>swagger2openapi>better-ajv-errors>jsonpointer>oas-validator>ajv": {
"decision": "ignore",
"madeAt": 1656679005322
},
"1068310|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>ejs>markdown-it>sanitize-html>widdershins>swagger2openapi>better-ajv-errors>jsonpointer>oas-validator>ajv>yargs>yargs-parser": {
"decision": "ignore",
"madeAt": 1656679007475
},
"1068310|widdershins>markdown-it>swagger2openapi>better-ajv-errors>jsonpointer>oas-validator>ajv>yargs>yargs-parser": {
"decision": "ignore",
"madeAt": 1656679007475
},
"1070412|shins>ejs": {
"decision": "ignore",
"madeAt": 1656679958471
},
"1070030|shins>ejs>markdown-it": {
"decision": "ignore",
"madeAt": 1656679961621
},
"1068155|shins>ejs>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1656679964361
},
"1070260|shins>ejs>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1656679966871
},
"1070030|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>markdown-it": {
"decision": "ignore",
"madeAt": 1656681873020
},
"1068155|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1656681876693
},
"1070260|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1656681880214
"madeAt": 1657188202661,
"expiresAt": 1659780190646
},
"1068310|widdershins>markdown-it>yargs>yargs-parser": {
"decision": "ignore",
"madeAt": 1656681883038
"madeAt": 1657188203603,
"expiresAt": 1659780190646
}
},
"rules": {},
Expand Down
6 changes: 4 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ services:
- "4002:4002"
depends_on:
- redis
command: sh -c "/wait4/wait4.js sdk-scheme-adapter; node src/index.js"
command: sh -c "/tmp/wait4/wait4.js sdk-scheme-adapter && npm run start"
# command: sh -c "/tmp/wait4/wait4.js sdk-scheme-adapter && sleep 999999"
volumes:
- ./docker/wait4:/wait4
- ./docker/wait4:/tmp/wait4
- ./secrets:/opt/app/secrets

ml-testing-toolkit:
networks:
Expand Down
Loading