Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/#2433): sdk-scheme-adapter v11.18.5 release fails to start #282

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Aug 26, 2021

  • Updated .gitignore with devspace, logs and IGNORE patterns
  • Moved @mojaloop peerDependencies to dependencies. Generally we would only add the @mojaloop dependencies as peerDependencies to libraries, but in this case the sdk-scheme-adapter is a standalone service, and as a result should not be a dependency to any other service. This fixes mojaloop/#2433.
  • Upgraded all dependencies except ws v8.x, which has some breaking changes. This will need to be addressed in future. ws was upgraded to the latest 7.x compatible version for the time being.

…tartup

- Updated .gitignore with devspace, logs and IGNORE patterns
- Moved @mojaloop peerDependencies to dependencies. Generally we would only add the @mojaloop dependencies as peerDependencies to libraries, but in this case the sdk-scheme-adapter is a standalone service, and as a result should not be a dependency to any other service.
@mdebarros mdebarros self-assigned this Aug 26, 2021
- Upgraded all dependencies except ws, which has some breaking changes. This will need to be addressed in future.
@mdebarros mdebarros marked this pull request as ready for review August 26, 2021 10:59
@mdebarros mdebarros requested a review from kirgene as a code owner August 26, 2021 10:59
- removed the event-sdk from devDepdendencies as its a dependency already
- also upgraded ws to the latest 7.x version
elnyry-sam-k
elnyry-sam-k previously approved these changes Aug 26, 2021
@mdebarros mdebarros merged commit 3c50416 into mojaloop:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdk-scheme-adapter v11.18.5 release failing on startup
2 participants