Skip to content

Commit

Permalink
fix: ws-connection-issue (#339)
Browse files Browse the repository at this point in the history
- downgraded ws lib dependency from v8.x to v7.5.5 due to breaking change that cause intermitant disconnections
- added ncurc.yaml file with ws lib dependency added with an appropriate comment
- added @mojaloop/api-snippets to dep:check ignore list as it requires PR [sdk-scheme-adapter/pull/340](#340) has been merged
  • Loading branch information
mdebarros authored Jul 27, 2022
1 parent 415bb33 commit e29e158
Show file tree
Hide file tree
Showing 6 changed files with 1,156 additions and 1,168 deletions.
7 changes: 7 additions & 0 deletions .ncurc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## Add a TODO comment indicating the reason for each rejected dependency upgrade added to this list, and what should be done to resolve it (i.e. handle it through a story, etc).
reject: [
## TODO: Breaking changes to ws lib dependency will need to be addressed in a future story. ref https://github.com/websockets/ws/releases/tag/8.0.0.
"ws",
## TODO: This will need to be removed, and upgraded once this PR https://github.com/mojaloop/sdk-scheme-adapter/pull/340 has been merged
"@mojaloop/api-snippets"
]
32 changes: 31 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,32 @@
* [email protected]
# This is a comment.
# Each line is a file pattern followed by one or more owners.
## These owners will be the default owners for everything in
## the repo. Unless a later match takes precedence,
## @global-owner1 and @global-owner2 will be requested for
## review when someone opens a pull request.
#* @global-owner1 @global-owner2
* [email protected]
* @mdebarros @elnyry-sam-k @vijayg10 @kleyow
## Order is important; the last matching pattern takes the most
## precedence. When someone opens a pull request that only
## modifies JS files, only @js-owner and not the global
## owner(s) will be requested for a review.
# *.js @js-owner
## You can also use email addresses if you prefer. They'll be
## used to look up users just like we do for commit author
## emails.
#*.go [email protected]
# In this example, @doctocat owns any files in the build/logs
# directory at the root of the repository and any of its
# subdirectories.
# /build/logs/ @doctocat
## The `docs/*` pattern will match files like
## `docs/getting-started.md` but not further nested files like
## `docs/build-app/troubleshooting.md`.
# docs/* [email protected]
## In this example, @octocat owns any file in an apps directory
## anywhere in your repository.
#apps/ @octocat
## In this example, @doctocat owns any file in the `/docs`
## directory in the root of your repository.
#/docs/ @doctocat
30 changes: 30 additions & 0 deletions audit-resolve.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,36 @@
"decision": "ignore",
"madeAt": 1657621042651,
"expiresAt": 1660213039412
},
"1081761|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>moment": {
"decision": "ignore",
"madeAt": 1658860721215,
"expiresAt": 1661452716888
},
"1070030|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>moment>widdershins>markdown-it": {
"decision": "ignore",
"madeAt": 1658860722876,
"expiresAt": 1661452716888
},
"1070030|shins>markdown-it": {
"decision": "ignore",
"madeAt": 1658860722876,
"expiresAt": 1661452716888
},
"1068310|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>moment>widdershins>markdown-it>yargs>yargs-parser": {
"decision": "ignore",
"madeAt": 1658860723959,
"expiresAt": 1661452716888
},
"1068155|shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1658860724884,
"expiresAt": 1661452716888
},
"1070260|shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1658860725792,
"expiresAt": 1661452716888
}
},
"rules": {},
Expand Down
Loading

0 comments on commit e29e158

Please sign in to comment.