Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK Scheme Adapter] Enhance the requestToPayTransfer API process for Payer Acceptance flow #3347

Closed
23 of 34 tasks
PaulGregoryBaker opened this issue May 16, 2023 · 1 comment
Closed
23 of 34 tasks

[SDK Scheme Adapter] Enhance the requestToPayTransfer API process for Payer Acceptance flow #3347

PaulGregoryBaker opened this issue May 16, 2023 · 1 comment
Assignees
@vijayg10
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it pi-21 Issues prioritized for Program Increment 21 story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented May 16, 2023 •
edited by vijayg10
Loading

Goal:

As a DFSP using SDK to connect to Mojaloop
I want to enable the RTP flow
so that I can make use of this use case

Limitations
This does not support the OTP Authentication flow; I.e. when the Authentication Type is not provided in the /transactionRequest Inbound API.

Acceptance Criteria:
Payer DFSP SDK changes

  • Verify that the POST /transferRequest inbound API has the authentication Type added and returns the homeRTPTransactionId
  • Verify that the POST /requestToPayTransfer outbound API has the
    • homeRTPTransactionId (option) added
    • has the RequestToPayId renamed to transactionRequestId (To align with the standard naming)
  • Verify that the PUT /RequestToPay is triggered if the Payer rejects the request and a PUT \transactionRequest FSPIOP is received from Mojaloop

Payee DFSP Inbound Changes

  • Verify that the homeFTPTransactionId is supplied optionally to the POST /quoterequest
  • Verify that a functional test is added to the SDK repo for this.
  • Verify that the PUT /requestToPayTransfer response with an rejected result in a PUT \transactionRequest FSPIOP call to Mojaloop

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating

Tasks:

  • Updated to API-Snippets to accommodate the following [@vijayg10]
    • Update Payer POST /requestToPayTransfer sync request
    • Update Payer PUT /requestToPayTransfer sync request & response (I don't think we need to do anything here, but lets keep it in-case something changes)
    • Update Payee POST /quotesrequest
    • Update Payee GET /otp (handled by OTP story)
    • Update Payee POST /transfers
    • Add Payee PUT /RequestToPay
  • Updates to SDK-Scheme-Adapter [@vijayg10 ]
    • Update Payer POST /requestToPayTransfer
    • Update Payer PUT /requestToPayTransfer for accept quote/auth
    • Update Payer PUT /requestToPayTransfer for reject auth
    • Update Payee POST /quotesRequest
    • Update Payee POST /transfers
    • Add Payee PUT /requestToPay
  • Add functional end to end tests for requestToPay and requestToPayTransfer
  • Add unit tests
  • Test coverage
  • PR reviews

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker added story to-be-refined This story is ready to be groomed core-dev-squad labels May 16, 2023
@PaulGregoryBaker PaulGregoryBaker changed the title [SDK Scheme Adapter] Enhance the requestToPayTransfer API process [SDK Scheme Adapter] Enhance the requestToPayTransfer API process for direct Payer Acceptance flow May 16, 2023
@PaulGregoryBaker PaulGregoryBaker changed the title [SDK Scheme Adapter] Enhance the requestToPayTransfer API process for direct Payer Acceptance flow [SDK Scheme Adapter] Enhance the requestToPayTransfer API process for Payer Acceptance flow May 17, 2023
@PaulGregoryBaker PaulGregoryBaker added oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it and removed to-be-refined This story is ready to be groomed labels May 17, 2023
@mdebarros
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @PaulGregoryBaker @vijayg10

@mdebarros mdebarros mentioned this issue May 17, 2023
Open
21 tasks
@chris-me-law chris-me-law mentioned this issue May 18, 2023
Closed
@PaulGregoryBaker PaulGregoryBaker added the pi-21 Issues prioritized for Program Increment 21 label May 23, 2023
@mdebarros mdebarros mentioned this issue May 23, 2023
Merged
This was referenced May 25, 2023
Merged
Merged
Merged
vijayg10 added a commit to mojaloop/api-snippets that referenced this issue Jun 5, 2023
@vijayg10
feat(mojaloop/3347): enhance the request to pay transfer api process …
d24c889 
…for payer acceptance flow (#163)

feat([mojaloop/3347](mojaloop/project#3347)): enhance the request to pay transfer api process for payer acceptance flow

**Changes:**

SDK Backend API:
- Added `homeR2PTransactionId` and `transactionRequestId` to `POST /quoteRequest`
- Added `homeR2PTransactionId` to `POST /transfers`
- Added new API resource `PUT /requestToPay/{transactionRequestId}`

SDK Outbound API:
- Changed `requestToPayTransactionId` to `transactionRequestId` in `PUT /requestToPayTransfer`
- Added `homeR2PTransactionId` and `transactionRequestId` to `requestToPayTransferRequest`
- Fixed schema for `scenario` field in `requestToPayTransferRequest`
- Added `authenticationType` to `requestToPayTransferRequest`
- Changed `requestToPayTransactionId` to `transactionRequestId` in `requestToPayTransferResponse`
- Added `homeR2PTransactionId` to `requestToPayTransferResponse`
- Fixed schema of `quoteResponse` in `requestToPayTransferResponse`
- Added `authorizationResponse` to `requestToPayTransferResponse`
- Fixed schema of `fulfil` in `requestToPayTransferResponse`
@vijayg10 vijayg10 closed this as completed Jun 6, 2023
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 6, 2023
@mdebarros
feat(mojaloop/3344): enhance SDK Scheme Adaptor to support the reques…
3af06ce 
…t to Pay use case (#446)

feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344
- feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345
- feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347

---------

Co-authored-by: vijayg10 <[email protected]>
Co-authored-by: Vijay <[email protected]>

---------

BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information.
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 6, 2023
@mdebarros @vijayg10
feat(mojaloop/3344)!: enhance SDK Scheme Adaptor to support the reque…
388f1df 
…st to Pay use case (#446)

feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344
- feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345
- feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347

fix: updates for nx v16 changes (#449)
- updated main nx.json config affected branch to `master`
- removed deprecated `--all` from all `nx affected` NPM scripts

BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information.

---------

Co-authored-by: vijayg10 <[email protected]>
Co-authored-by: Vijay <[email protected]>
@mdebarros mdebarros removed their assignment Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijayg10 vijayg10

Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it pi-21 Issues prioritized for Program Increment 21 story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdebarros @vijayg10 @PaulGregoryBaker