fix for [core bulk] POST /bulkTransfers from Switch --> PayeeFSP to use Switch as fspiop-source #2867

[mdebarros]

Summary:
Bug is for Feat #2867.

The following validation error occurs on the Central-Ledger Bulk Transfer Fulfil Handler as a result of the following bulk-api-adapter/releases/tag/v14.2.0:

2022-11-17T16:59:56.855Z - info: BulkFulfilHandler::bulkFulfil
2022-11-17T16:59:56.856Z - info: BulkFulfilHandler::bulkFulfil::dupCheck
.returning() is not supported by mysql and will not have any effect.
2022-11-17T16:59:56.870Z - error: BulkFulfilHandler::bulkFulfil::validationFailed
2022-11-17T16:59:56.870Z - error: validationFailure Reasons - []
2022-11-17T16:59:56.870Z - info: BulkFulfilHandler::bulkFulfil::validationFailed::saveInvalidRequest
.returning() is not supported by mysql and will not have any effect.
.returning() is not supported by mysql and will not have any effect.
2022-11-17T16:59:56.897Z - info: BulkFulfilHandler::bulkFulfil::validationFailed::saveInvalidRequest::callbackErrorGeneric--BC8
2022-11-17T16:59:56.901Z - error: BulkFulfilHandler::bulkFulfil::validationFailed::saveInvalidRequest::callbackErrorGeneric--BC8::FSPIOP-Destination header should match Payer FSP--BP0
2022-11-17T16:59:56.901Z - error: FSPIOP-Destination header should match Payer FSP
2022-11-17T16:59:56.902Z - error: Consumer::consume()::syncQueue.queue - error: {"message":"FSPIOP-Destination header should match Payer FSP","apiErrorCode":{"code":"3100","message":"Generic validation error","httpStatusCode":400,"name":"VALIDATION_ERROR","type":{"regex":"^31[0-9]{2}$","description":"Client Validation Error","httpStatusCode":400,"name":"CLIENT_VALIDATION_ERROR"}}}
2022-11-17T16:59:56.902Z - error: Consumer::onError()[topics='topic-bulk-fulfil'] - FSPIOPError: FSPIOP-Destination header should match Payer FSP
    at Object.createFSPIOPError (/opt/app/node_modules/@mojaloop/central-services-error-handling/src/factory.js:198:12)
    at validateFspiopSourceAndDestination (/opt/app/src/handlers/bulk/shared/validator.js:101:28)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Object.validateBulkTransferFulfilment (/opt/app/src/handlers/bulk/shared/validator.js:206:24)
    at async bulkFulfil (/opt/app/src/handlers/bulk/fulfil/handler.js:118:34))
2022-11-17T16:59:56.903Z - error: Consumer::consume() - error {"message":"FSPIOP-Destination header should match Payer FSP","apiErrorCode":{"code":"3100","message":"Generic validation error","httpStatusCode":400,"name":"VALIDATION_ERROR","type":{"regex":"^31[0-9]{2}$","description":"Client Validation Error","httpStatusCode":400,"name":"CLIENT_VALIDATION_ERROR"}}}

Severity:
Medium

Priority:
Medium

Expected Behavior

• Switch should allow for incoming PUT Callback with Destination="Switch" to validate if the outgoing POST Requests Source="Switch".

Steps to Reproduce

1. Deploy the following Helm Branch with the following enabled --> feat(mojaloop/2867): post /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source helm#528
   • --set "mojaloop-bulk.enabled: true"
   • -- set "ml-ttk-test-val-bulk.tests.enabled=true"
2. Run helm test

Specifications

• Component (if known): bulk-api-adapter
• Version: v14.2.0
• Platform: n/a
• Subsystem:
• Type of testing: helm
• Bug found/raised by: @mdebarros

Notes:

• Severity when opened: Medium
• Priority when opened: Medium

[mdebarros]

PRs:

• fix(mojaloop/#3024): [core bulk] POST /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source testing-toolkit-test-cases#98
• fix(mojaloop/#3024): post /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source central-ledger#926

[mdebarros]

Test results available here: mojaloop/helm#528 (comment)