feat!: #2100 allow config options to be passed through to Mongoose #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisdaly
changed the title
85 tasks
lewisdaly
requested review from
elnyry-sam-k,
oderayi and
shashi165
as code owners
|
I've validated this on central-ledger with some integration tests. |
|
@elnyry-sam-k who is the best person to review this? |
|
@vgenev , @mdebarros can you please help with this |
|
Bump @vgenev @mdebarros |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of mojaloop/project#2100
Additionally:
BREAKING CHANGE: I removed what looks like redundant schemas and models, but since they could potentially still be accessed by a client library, I consider this a breaking change