Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: added the source header while sending notification #78

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Bug Fix: added the source header while sending notification #78

merged 1 commit into from
Dec 5, 2018

Conversation

shashi165
Copy link
Contributor

Fix for the bug #540

  1. added the source header while sending the notification

Unit Tests

1..152
# tests 152
# pass  152

ok

Coverage Tests

=============================== Coverage summary ===============================
Statements   : 100% ( 521/521 )
Branches     : 100% ( 103/103 )
Functions    : 100% ( 55/55 )
Lines        : 100% ( 521/521 )
================================================================================

@shashi165 shashi165 self-assigned this Dec 5, 2018
@elnyry-sam-k elnyry-sam-k mentioned this pull request Dec 5, 2018
Closed
4 tasks
rmothilal
rmothilal approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy

@shashi165 shashi165 merged commit aff5cac into mojaloop:develop Dec 5, 2018
ksatya77
ksatya77 reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@ksatya77 ksatya77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@rasputtintin rasputtintin mentioned this pull request May 20, 2022
Open
@rasputtintin rasputtintin mentioned this pull request Aug 24, 2023
Open
@rasputtintin rasputtintin mentioned this pull request Nov 28, 2023
Open
@rasputtintin rasputtintin mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksatya77 ksatya77 ksatya77 left review comments

@rmothilal rmothilal rmothilal approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@mdebarros mdebarros Awaiting requested review from mdebarros

Assignees

@shashi165 shashi165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shashi165 @ksatya77 @rmothilal