Story #357 cleanup ml-api-adapter project #57

shashi165 · 2018-10-03T21:18:52Z

Changes

configured the jsdocs
added documentation wherever it was missing
added more logging
cleaned up unused code/configurations
cleaned up package.json
updated the npm package versions to latest

Unit Tests

1..159
# tests 159
# pass  159

# ok

Coverage Tests

Statements   : 100% ( 486/486 )
Branches     : 100% ( 101/101 )
Functions    : 100% ( 49/49 )
Lines        : 100% ( 486/486 )

Integration Tests

View Results

<?xml version="1.0"?>
<testsuites>
  <testsuite tests="0" failures="0" errors="0" name="setup"/>
  <testsuite tests="0" failures="0" errors="0" name="transfer service"/>
  <testsuite tests="0" failures="0" errors="0" name="prepare should"/>
  <testsuite tests="2" failures="0" errors="0" name="produce a transfer message to kafka">
    <testcase name="#1 should be equal"/>
    <testcase name="#2 (unnamed assert)">
      <system-out>2018-10-03T21:15:33.539Z - [32minfo[39m: Producer::start::topic=topic-dfsp2-transfer-prepare
</system-out>
      <system-out>2018-10-03T21:15:33.542Z - [32minfo[39m: Producer::connect::start
</system-out>
      <system-out>2018-10-03T21:15:33.573Z - [32minfo[39m: Producer::connect::end
</system-out>
      <system-out>2018-10-03T21:15:33.573Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"id":"caca1f25-0f0f-427d-a225-5f68a0b80196","to":"dfsp1","from":"dfsp2","type":"application/json","content":{"headers":{},"payload":{"transferId":"caca1f25-0f0f-427d-a225-5f68a0b80196","payeeFsp":"dfsp1","payerFsp":"dfsp2","amount":{"currency":"USD","amount":"123.45"},"ilpPacket":"AYIBgQAAAAAAAASwNGxldmVsb25lLmRmc3AxLm1lci45T2RTOF81MDdqUUZERmZlakgyOVc4bXFmNEpLMHlGTFGCAUBQU0svMS4wCk5vbmNlOiB1SXlweUYzY3pYSXBFdzVVc05TYWh3CkVuY3J5cHRpb246IG5vbmUKUGF5bWVudC1JZDogMTMyMzZhM2ItOGZhOC00MTYzLTg0NDctNGMzZWQzZGE5OGE3CgpDb250ZW50LUxlbmd0aDogMTM1CkNvbnRlbnQtVHlwZTogYXBwbGljYXRpb24vanNvbgpTZW5kZXItSWRlbnRpZmllcjogOTI4MDYzOTEKCiJ7XCJmZWVcIjowLFwidHJhbnNmZXJDb2RlXCI6XCJpbnZvaWNlXCIsXCJkZWJpdE5hbWVcIjpcImFsaWNlIGNvb3BlclwiLFwiY3JlZGl0TmFtZVwiOlwibWVyIGNoYW50XCIsXCJkZWJpdElkZW50aWZpZXJcIjpcIjkyODA2MzkxXCJ9IgA","condition":"f5sqb7tBTWPd5Y8BDFdMm9BJR_MNI4isf8p8n4D5pHA","expiration":"2016-05-24T08:38:08.699-04:00","extensionList":{"extension":[{"key":"errorDescription","value":"This is a more detailed error description"},{"key":"errorDescription","value":"This is a more detailed error description"}]}}},"metadata":{"event":{"id":"f42a2c66-e6e0-4af5-bf8e-a1a718bf5534","type":"prepare","action":"prepare","createdAt":"2018-10-03T21:15:33.533Z","state":{"status":"success","code":0}}}}'
</system-out>
      <system-out>2018-10-03T21:15:33.575Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="0" failures="0" errors="0" name="Notification Handler"/>
  <testsuite tests="1" failures="0" errors="0" name="setup connect to kafka">
    <testcase name="#3 Connected to kafka successfully">
      <system-out>2018-10-03T21:15:33.610Z - [32minfo[39m: Producer::start::topic=topic-notification-event
</system-out>
      <system-out>2018-10-03T21:15:33.610Z - [32minfo[39m: Producer::connect::start
</system-out>
      <system-out>2018-10-03T21:15:33.669Z - [32minfo[39m: Producer::connect::end
</system-out>
      <system-out>2018-10-03T21:15:33.670Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"3afb1a3d-4bc9-415e-a29f-0938b666b6d2","createdAt":"2018-10-03T21:15:33.610Z","type":"prepare","action":"prepare","state":{"status":"success","code":0}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"amount":{"amount":100,"currency":"USD"},"condition":"uU0nuZNNPgilLlLX2n2r-sSE7-N6U4DukIj3rOLvze1","expiration":"2018-08-24T21:31:00.534+01:00","ilpPacket":"AQAAAAAAAABkEGcuZXdwMjEuaWQuODAwMjCCAhd7InRyYW5zYWN0aW9uSWQiOiJmODU0NzdkYi0xMzVkLTRlMDgtYThiNy0xMmIyMmQ4MmMwZDYiLCJxdW90ZUlkIjoiOWU2NGYzMjEtYzMyNC00ZDI0LTg5MmYtYzQ3ZWY0ZThkZTkxIiwicGF5ZWUiOnsicGFydHlJZEluZm8iOnsicGFydHlJZFR5cGUiOiJNU0lTRE4iLCJwYXJ0eUlkZW50aWZpZXIiOiIyNTYxMjM0NTYiLCJmc3BJZCI6IjIxIn19LCJwYXllciI6eyJwYXJ0eUlkSW5mbyI6eyJwYXJ0eUlkVHlwZSI6Ik1TSVNETiIsInBhcnR5SWRlbnRpZmllciI6IjI1NjIwMTAwMDAxIiwiZnNwSWQiOiIyMCJ9LCJwZXJzb25hbEluZm8iOnsiY29tcGxleE5hbWUiOnsiZmlyc3ROYW1lIjoiTWF0cyIsImxhc3ROYW1lIjoiSGFnbWFuIn0sImRhdGVPZkJpcnRoIjoiMTk4My0xMC0yNSJ9fSwiYW1vdW50Ijp7ImFtb3VudCI6IjEwMCIsImN1cnJlbmN5IjoiVVNEIn0sInRyYW5zYWN0aW9uVHlwZSI6eyJzY2VuYXJpbyI6IlRSQU5TRkVSIiwiaW5pdGlhdG9yIjoiUEFZRVIiLCJpbml0aWF0b3JUeXBlIjoiQ09OU1VNRVIifSwibm90ZSI6ImhlaiJ9","payeeFsp":"dfsp1","payerFsp":"dfsp2","transferId":"4c04e7d8-bc35-49a8-b3d7-7cddbbb41439"}},"to":"dfsp2","from":"dfsp1","id":"4c04e7d8-bc35-49a8-b3d7-7cddbbb41439","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:33.671Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="0" failures="0" errors="0" name="setup disconnect from kafka"/>
  <testsuite tests="0" failures="0" errors="0" name="Notification Handler should"/>
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a PREPARE message and send POST callback">
    <testcase name="#4 Notification sent successfully to Payee">
      <system-out>2018-10-03T21:15:35.746Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"67deecf2-a7cd-41f4-8de6-062a5b1f1291","createdAt":"2018-10-03T21:15:35.746Z","type":"prepare","action":"prepare","state":{"code":3100,"description":"Generic validation error","status":"error"}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"errorInformation":{"errorCode":3100,"errorDescription":"Generic validation error"}}},"to":"dfsp2","from":"dfsp1","id":"d66bf5db-083f-441b-9811-85c3716e7228","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:35.747Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a PREPARE message and send PUT callback on error">
    <testcase name="#5 Error notification sent successfully to Payer">
      <system-out>2018-10-03T21:15:37.767Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"43dd3732-3e0e-4f73-b0a8-ed34c57d364f","createdAt":"2018-10-03T21:15:37.767Z","type":"commit","action":"commit","state":{"status":"success","code":0}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"amount":{"amount":100,"currency":"USD"},"transferState":"COMMITTED","fulfilment":"f5sqb7tBTWPd5Y8BDFdMm9BJR_MNI4isf8p8n4D5pHA","condition":"uU0nuZNNPgilLlLX2n2r-sSE7-N6U4DukIj3rOLvze1","expiration":"2018-08-24T21:31:00.534+01:00","ilpPacket":"AQAAAAAAAABkEGcuZXdwMjEuaWQuODAwMjCCAhd7InRyYW5zYWN0aW9uSWQiOiJmODU0NzdkYi0xMzVkLTRlMDgtYThiNy0xMmIyMmQ4MmMwZDYiLCJxdW90ZUlkIjoiOWU2NGYzMjEtYzMyNC00ZDI0LTg5MmYtYzQ3ZWY0ZThkZTkxIiwicGF5ZWUiOnsicGFydHlJZEluZm8iOnsicGFydHlJZFR5cGUiOiJNU0lTRE4iLCJwYXJ0eUlkZW50aWZpZXIiOiIyNTYxMjM0NTYiLCJmc3BJZCI6IjIxIn19LCJwYXllciI6eyJwYXJ0eUlkSW5mbyI6eyJwYXJ0eUlkVHlwZSI6Ik1TSVNETiIsInBhcnR5SWRlbnRpZmllciI6IjI1NjIwMTAwMDAxIiwiZnNwSWQiOiIyMCJ9LCJwZXJzb25hbEluZm8iOnsiY29tcGxleE5hbWUiOnsiZmlyc3ROYW1lIjoiTWF0cyIsImxhc3ROYW1lIjoiSGFnbWFuIn0sImRhdGVPZkJpcnRoIjoiMTk4My0xMC0yNSJ9fSwiYW1vdW50Ijp7ImFtb3VudCI6IjEwMCIsImN1cnJlbmN5IjoiVVNEIn0sInRyYW5zYWN0aW9uVHlwZSI6eyJzY2VuYXJpbyI6IlRSQU5TRkVSIiwiaW5pdGlhdG9yIjoiUEFZRVIiLCJpbml0aWF0b3JUeXBlIjoiQ09OU1VNRVIifSwibm90ZSI6ImhlaiJ9","payeeFsp":"dfsp1","payerFsp":"dfsp2","transferId":"063e946e-408f-4607-afa2-f8680305377f"}},"to":"dfsp2","from":"dfsp1","id":"063e946e-408f-4607-afa2-f8680305377f","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:37.767Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="2" failures="0" errors="0" name="Notification Handler should consume a COMMIT message and send PUT callback">
    <testcase name="#6 Notification sent successfully to Payer"/>
    <testcase name="#7 Notification sent successfully to Payee">
      <system-out>2018-10-03T21:15:39.788Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"214e52ce-1cf2-4880-a1a6-cb41b405e156","createdAt":"2018-10-03T21:15:39.788Z","type":"commit","action":"commit","state":{"code":3000,"description":"Generic error","status":"error"}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"errorInformation":{"errorCode":3000,"errorDescription":"Generic error"}}},"to":"dfsp2","from":"dfsp1","id":"d654eb7d-4ee5-476e-95f2-5262e3cb08c9","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:39.789Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a COMMIT message and send PUT callback on error">
    <testcase name="#8 Notification sent successfully to Payer">
      <system-out>2018-10-03T21:15:41.802Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"f9d783b4-38fc-455a-8163-2c5bed81143c","createdAt":"2018-10-03T21:15:41.802Z","type":"reject","action":"reject","state":{"status":"success","code":0}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"amount":{"amount":100,"currency":"USD"},"transferState":"COMMITTED","fulfilment":"f5sqb7tBTWPd5Y8BDFdMm9BJR_MNI4isf8p8n4D5pHA","condition":"uU0nuZNNPgilLlLX2n2r-sSE7-N6U4DukIj3rOLvze1","expiration":"2018-08-24T21:31:00.534+01:00","ilpPacket":"AQAAAAAAAABkEGcuZXdwMjEuaWQuODAwMjCCAhd7InRyYW5zYWN0aW9uSWQiOiJmODU0NzdkYi0xMzVkLTRlMDgtYThiNy0xMmIyMmQ4MmMwZDYiLCJxdW90ZUlkIjoiOWU2NGYzMjEtYzMyNC00ZDI0LTg5MmYtYzQ3ZWY0ZThkZTkxIiwicGF5ZWUiOnsicGFydHlJZEluZm8iOnsicGFydHlJZFR5cGUiOiJNU0lTRE4iLCJwYXJ0eUlkZW50aWZpZXIiOiIyNTYxMjM0NTYiLCJmc3BJZCI6IjIxIn19LCJwYXllciI6eyJwYXJ0eUlkSW5mbyI6eyJwYXJ0eUlkVHlwZSI6Ik1TSVNETiIsInBhcnR5SWRlbnRpZmllciI6IjI1NjIwMTAwMDAxIiwiZnNwSWQiOiIyMCJ9LCJwZXJzb25hbEluZm8iOnsiY29tcGxleE5hbWUiOnsiZmlyc3ROYW1lIjoiTWF0cyIsImxhc3ROYW1lIjoiSGFnbWFuIn0sImRhdGVPZkJpcnRoIjoiMTk4My0xMC0yNSJ9fSwiYW1vdW50Ijp7ImFtb3VudCI6IjEwMCIsImN1cnJlbmN5IjoiVVNEIn0sInRyYW5zYWN0aW9uVHlwZSI6eyJzY2VuYXJpbyI6IlRSQU5TRkVSIiwiaW5pdGlhdG9yIjoiUEFZRVIiLCJpbml0aWF0b3JUeXBlIjoiQ09OU1VNRVIifSwibm90ZSI6ImhlaiJ9","payeeFsp":"dfsp1","payerFsp":"dfsp2","transferId":"d5677368-3a4e-4d1c-beff-d91896daa800"}},"to":"dfsp2","from":"dfsp1","id":"d5677368-3a4e-4d1c-beff-d91896daa800","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:41.802Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="2" failures="0" errors="0" name="Notification Handler should consume a REJECT message and send PUT callback">
    <testcase name="#9 Notification sent successfully to Payer"/>
    <testcase name="#10 Notification sent successfully to Payee">
      <system-out>2018-10-03T21:15:43.831Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"fdb0cd80-38b0-4467-890f-0b02f1f3e601","createdAt":"2018-10-03T21:15:43.831Z","type":"abort","action":"abort","state":{"status":"success","code":0}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"amount":{"amount":100,"currency":"USD"},"transferState":"COMMITTED","fulfilment":"f5sqb7tBTWPd5Y8BDFdMm9BJR_MNI4isf8p8n4D5pHA","condition":"uU0nuZNNPgilLlLX2n2r-sSE7-N6U4DukIj3rOLvze1","expiration":"2018-08-24T21:31:00.534+01:00","ilpPacket":"AQAAAAAAAABkEGcuZXdwMjEuaWQuODAwMjCCAhd7InRyYW5zYWN0aW9uSWQiOiJmODU0NzdkYi0xMzVkLTRlMDgtYThiNy0xMmIyMmQ4MmMwZDYiLCJxdW90ZUlkIjoiOWU2NGYzMjEtYzMyNC00ZDI0LTg5MmYtYzQ3ZWY0ZThkZTkxIiwicGF5ZWUiOnsicGFydHlJZEluZm8iOnsicGFydHlJZFR5cGUiOiJNU0lTRE4iLCJwYXJ0eUlkZW50aWZpZXIiOiIyNTYxMjM0NTYiLCJmc3BJZCI6IjIxIn19LCJwYXllciI6eyJwYXJ0eUlkSW5mbyI6eyJwYXJ0eUlkVHlwZSI6Ik1TSVNETiIsInBhcnR5SWRlbnRpZmllciI6IjI1NjIwMTAwMDAxIiwiZnNwSWQiOiIyMCJ9LCJwZXJzb25hbEluZm8iOnsiY29tcGxleE5hbWUiOnsiZmlyc3ROYW1lIjoiTWF0cyIsImxhc3ROYW1lIjoiSGFnbWFuIn0sImRhdGVPZkJpcnRoIjoiMTk4My0xMC0yNSJ9fSwiYW1vdW50Ijp7ImFtb3VudCI6IjEwMCIsImN1cnJlbmN5IjoiVVNEIn0sInRyYW5zYWN0aW9uVHlwZSI6eyJzY2VuYXJpbyI6IlRSQU5TRkVSIiwiaW5pdGlhdG9yIjoiUEFZRVIiLCJpbml0aWF0b3JUeXBlIjoiQ09OU1VNRVIifSwibm90ZSI6ImhlaiJ9","payeeFsp":"dfsp1","payerFsp":"dfsp2","transferId":"1cdbf502-8642-4eeb-8fd3-4a9bd7e5313e"}},"to":"dfsp2","from":"dfsp1","id":"1cdbf502-8642-4eeb-8fd3-4a9bd7e5313e","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:43.831Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="2" failures="0" errors="0" name="Notification Handler should consume a ABORT message and send PUT callback">
    <testcase name="#11 Notification sent successfully to Payer"/>
    <testcase name="#12 Notification sent successfully to Payee">
      <system-out>2018-10-03T21:15:45.866Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"9805faa9-54ad-4152-872e-498660dbcec0","createdAt":"2018-10-03T21:15:45.866Z","type":"prepare","action":"timeout-received","state":{"status":"success","code":0}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"amount":{"amount":100,"currency":"USD"},"transferState":"COMMITTED","fulfilment":"f5sqb7tBTWPd5Y8BDFdMm9BJR_MNI4isf8p8n4D5pHA","condition":"uU0nuZNNPgilLlLX2n2r-sSE7-N6U4DukIj3rOLvze1","expiration":"2018-08-24T21:31:00.534+01:00","ilpPacket":"AQAAAAAAAABkEGcuZXdwMjEuaWQuODAwMjCCAhd7InRyYW5zYWN0aW9uSWQiOiJmODU0NzdkYi0xMzVkLTRlMDgtYThiNy0xMmIyMmQ4MmMwZDYiLCJxdW90ZUlkIjoiOWU2NGYzMjEtYzMyNC00ZDI0LTg5MmYtYzQ3ZWY0ZThkZTkxIiwicGF5ZWUiOnsicGFydHlJZEluZm8iOnsicGFydHlJZFR5cGUiOiJNU0lTRE4iLCJwYXJ0eUlkZW50aWZpZXIiOiIyNTYxMjM0NTYiLCJmc3BJZCI6IjIxIn19LCJwYXllciI6eyJwYXJ0eUlkSW5mbyI6eyJwYXJ0eUlkVHlwZSI6Ik1TSVNETiIsInBhcnR5SWRlbnRpZmllciI6IjI1NjIwMTAwMDAxIiwiZnNwSWQiOiIyMCJ9LCJwZXJzb25hbEluZm8iOnsiY29tcGxleE5hbWUiOnsiZmlyc3ROYW1lIjoiTWF0cyIsImxhc3ROYW1lIjoiSGFnbWFuIn0sImRhdGVPZkJpcnRoIjoiMTk4My0xMC0yNSJ9fSwiYW1vdW50Ijp7ImFtb3VudCI6IjEwMCIsImN1cnJlbmN5IjoiVVNEIn0sInRyYW5zYWN0aW9uVHlwZSI6eyJzY2VuYXJpbyI6IlRSQU5TRkVSIiwiaW5pdGlhdG9yIjoiUEFZRVIiLCJpbml0aWF0b3JUeXBlIjoiQ09OU1VNRVIifSwibm90ZSI6ImhlaiJ9","payeeFsp":"dfsp1","payerFsp":"dfsp2","transferId":"3f3826f3-c36b-4e05-8016-63304da01c9e"}},"to":"dfsp2","from":"dfsp1","id":"3f3826f3-c36b-4e05-8016-63304da01c9e","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:45.867Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a TIMEOUT-RECEIVED message and send PUT callback">
    <testcase name="#13 Notification sent successfully to Payer">
      <system-out>2018-10-03T21:15:47.881Z - [32minfo[39m: Producer.sendMessage:: messageProtocol:'{"metadata":{"event":{"id":"407f88cd-a1eb-4c47-b8e8-aeea0eb3a8fb","createdAt":"2018-10-03T21:15:47.880Z","type":"prepare","action":"prepare-duplicate","state":{"status":"success","code":0}}},"content":{"headers":{"content-length":1038,"content-type":"application/json","date":"2017-11-02T00:00:00.000Z","fspiop-destination":"dfsp2","fspiop-source":"dfsp1"},"payload":{"amount":{"amount":100,"currency":"USD"},"transferState":"COMMITTED","completedTimestamp":"2018-08-23T21:31:00.534+01:00","fulfilment":"f5sqb7tBTWPd5Y8BDFdMm9BJR_MNI4isf8p8n4D5pHA","condition":"uU0nuZNNPgilLlLX2n2r-sSE7-N6U4DukIj3rOLvze1","expiration":"2018-08-24T21:31:00.534+01:00","ilpPacket":"AQAAAAAAAABkEGcuZXdwMjEuaWQuODAwMjCCAhd7InRyYW5zYWN0aW9uSWQiOiJmODU0NzdkYi0xMzVkLTRlMDgtYThiNy0xMmIyMmQ4MmMwZDYiLCJxdW90ZUlkIjoiOWU2NGYzMjEtYzMyNC00ZDI0LTg5MmYtYzQ3ZWY0ZThkZTkxIiwicGF5ZWUiOnsicGFydHlJZEluZm8iOnsicGFydHlJZFR5cGUiOiJNU0lTRE4iLCJwYXJ0eUlkZW50aWZpZXIiOiIyNTYxMjM0NTYiLCJmc3BJZCI6IjIxIn19LCJwYXllciI6eyJwYXJ0eUlkSW5mbyI6eyJwYXJ0eUlkVHlwZSI6Ik1TSVNETiIsInBhcnR5SWRlbnRpZmllciI6IjI1NjIwMTAwMDAxIiwiZnNwSWQiOiIyMCJ9LCJwZXJzb25hbEluZm8iOnsiY29tcGxleE5hbWUiOnsiZmlyc3ROYW1lIjoiTWF0cyIsImxhc3ROYW1lIjoiSGFnbWFuIn0sImRhdGVPZkJpcnRoIjoiMTk4My0xMC0yNSJ9fSwiYW1vdW50Ijp7ImFtb3VudCI6IjEwMCIsImN1cnJlbmN5IjoiVVNEIn0sInRyYW5zYWN0aW9uVHlwZSI6eyJzY2VuYXJpbyI6IlRSQU5TRkVSIiwiaW5pdGlhdG9yIjoiUEFZRVIiLCJpbml0aWF0b3JUeXBlIjoiQ09OU1VNRVIifSwibm90ZSI6ImhlaiJ9","payeeFsp":"dfsp1","payerFsp":"dfsp2","transferId":"76ba4807-3e82-4476-ab47-c5d64b17c872"}},"to":"dfsp2","from":"dfsp1","id":"76ba4807-3e82-4476-ab47-c5d64b17c872","type":"application/json"}'
</system-out>
      <system-out>2018-10-03T21:15:47.881Z - [32minfo[39m: Producer::end
</system-out>
    </testcase>
  </testsuite>
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a PREPARE-DUPLICATE message and send PUT callback">
    <testcase name="#14 Notification sent successfully to Payer"/>
  </testsuite>
  <testsuite tests="0" failures="0" errors="0" name="Notification Handler should tear down"/>
</testsuites>

rmothilal

Please see comment

rmothilal · 2018-10-03T21:37:30Z

src/handlers/register.js

@@ -40,7 +43,7 @@ const NotificationHandler = require('./notification')
 * @returns {boolean} - Returns a boolean: true if successful, or throws and error if failed
 */
 const registerAllHandlers = async (request, h) => {
-  return await NotificationHandler.startConsumer()


why is this not await??

Shashi added 3 commits October 2, 2018 16:38

added logging and jsdocs

2615fac

cleaned up the package.json, updated the npm versions

a131cac

cleaned up the package.json, updated the npm versions

2203a14

shashi165 self-assigned this Oct 3, 2018

shashi165 requested review from ksatya77 and rmothilal October 3, 2018 21:18

rmothilal requested changes Oct 3, 2018

View reviewed changes

rmothilal approved these changes Oct 3, 2018

View reviewed changes

shashi165 merged commit 886bd82 into mojaloop:develop Oct 3, 2018

elnyry-sam-k mentioned this pull request Oct 3, 2018

Review ml-api-adapter repo for quality mojaloop/project#357

Closed

9 tasks

rasputtintin mentioned this pull request May 20, 2022

[Snyk] Fix for 3 vulnerabilities rasputtintin/ml-api-adapter#26

Open

rasputtintin mentioned this pull request Aug 24, 2023

[Snyk] Fix for 5 vulnerabilities rasputtintin/ml-api-adapter#28

Open

rasputtintin mentioned this pull request Nov 28, 2023

[Snyk] Fix for 7 vulnerabilities rasputtintin/ml-api-adapter#32

Open

rasputtintin mentioned this pull request Dec 6, 2023

[Snyk] Fix for 1 vulnerabilities rasputtintin/ml-api-adapter#34

Open

rasputtintin mentioned this pull request Dec 19, 2023

[Snyk] Fix for 26 vulnerabilities rasputtintin/ml-api-adapter#36

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Story #357 cleanup ml-api-adapter project #57

Story #357 cleanup ml-api-adapter project #57

shashi165 commented Oct 3, 2018 •

edited

Loading

rmothilal left a comment

rmothilal Oct 3, 2018

Story #357 cleanup ml-api-adapter project #57

Story #357 cleanup ml-api-adapter project #57

Conversation

shashi165 commented Oct 3, 2018 • edited Loading

Changes

Unit Tests

Coverage Tests

Integration Tests

rmothilal left a comment

Choose a reason for hiding this comment

rmothilal Oct 3, 2018

Choose a reason for hiding this comment

shashi165 commented Oct 3, 2018 •

edited

Loading