Fix/869 duplicate response header validation #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmothilal
approved these changes
Jul 25, 2019
| @@ -59,6 +60,10 @@ const prepare = async (headers, message, dataUri) => { | |||
| from: message.payerFsp, | |||
| type: 'application/json', | |||
| content: { | |||
| // TODO: will message.transferId always exist? | |||
There was a problem hiding this comment.
On a prepare you should always have a message.transferId as it is required by Joi validation
|
As discussed, hold off merging this for now until we address some of the message formatting issues. |
|
This will be merged as a temporary fix. See the following story for the long-term solution to be implemented: mojaloop/project#886 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in the message creation in
src/domain/transfer/index.js, which was causing downstream errors when checking for duplicate transfers.Added new unit tests to validate the message.