Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/746-748-747 Implement Bulk Transfer Fulfil #118

Conversation

ggrg
Copy link
Member

@ggrg ggrg commented Jun 23, 2019

Stories #746, #747, #748

ggrg and others added 30 commits June 12, 2019 17:50
Switched to message.id=UUID for fulfil and get
28 unit tests fail
Re-factored objStore lib to be re-usable between both ml-api and central-ledger
…-adapter into feature/746-748-747ImplementBulkTransferFulfil
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

package.json Outdated Show resolved Hide resolved
src/bulkApi/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@@ -17,12 +17,11 @@
"registry": "https://registry.npmjs.org"
},
"dependencies": {
"@mojaloop/central-object-store": "6.4.0-snapshot",
"@mojaloop/central-object-store": "file:../../../../../npmpack/mojaloop-central-object-store-6.4.1-snapshot.tgz",
"@mojaloop/central-services-shared": "^5.2.0",
"boom": "^7.1.1",
"hapi": "^17.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update dependencies and remove carets ^

@ggrg ggrg merged commit 0de9217 into mojaloop:feature/bulkTransfersPoc Jun 24, 2019
@ggrg ggrg deleted the feature/746-748-747ImplementBulkTransferFulfil branch June 24, 2019 13:16
@ggrg ggrg restored the feature/746-748-747ImplementBulkTransferFulfil branch February 27, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants