Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Bulk Transfers POC - Bulk prepare #116

Merged
merged 26 commits into from
Jun 20, 2019
Merged

Feature/Bulk Transfers POC - Bulk prepare #116

merged 26 commits into from
Jun 20, 2019

Conversation

ggrg
Copy link
Member

@ggrg ggrg commented Jun 19, 2019

Story #747 and Story #748

  • Bulk Transfer Prepare golden path end-to-end

@ggrg ggrg self-assigned this Jun 19, 2019
This was referenced Jun 19, 2019
Closed
Closed
rmothilal
rmothilal approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy

mdebarros
mdebarros requested changes Jun 19, 2019
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See some minor comments below for your response.

src/bulkApi/handlers/bulkTransfers.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/models/mongo/bulkTransfer.js Outdated Show resolved Hide resolved
mdebarros and others added 2 commits June 20, 2019 17:57
@mdebarros
Re-factored objStore lib to be re-usable between both ml-api and cent…
2c02a6d 
…ral-ledger
@ggrg
Merge pull request #1 from mdebarros/feature/bulkTransfersPocObjStoreLib
7062e52 
Re-factored objStore lib to be re-usable between both ml-api and central-ledger
@ggrg ggrg merged commit efcf7c4 into mojaloop:feature/bulkTransfersPoc Jun 20, 2019
@ggrg ggrg deleted the feature/bulkTransfersPoc branch June 20, 2019 19:12
@rasputtintin rasputtintin mentioned this pull request May 20, 2022
Open
@rasputtintin rasputtintin mentioned this pull request Aug 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmothilal rmothilal rmothilal approved these changes

@mdebarros mdebarros mdebarros approved these changes

@lewisdaly lewisdaly lewisdaly approved these changes

@vgenev vgenev Awaiting requested review from vgenev

@NicoDuvenage NicoDuvenage Awaiting requested review from NicoDuvenage

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

Assignees

@ggrg ggrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggrg @lewisdaly @mdebarros @rmothilal