Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hard coded pull secret in mojaloop simulator chart #629

Merged
merged 2 commits into from
May 28, 2024

Conversation

vijayg10
Copy link
Contributor

@vijayg10 vijayg10 commented May 6, 2024

Kubernetes deployment gives warnings for pull secret "dock-casa-secret" because there is hard coded reference in mojaloop simulator chart.

@vijayg10 vijayg10 requested a review from dfry May 6, 2024 11:14
@vijayg10 vijayg10 self-assigned this May 6, 2024
elnyry-sam-k
elnyry-sam-k previously approved these changes May 6, 2024
@elnyry-sam-k
Copy link
Member

@vijayg10 the test step is failing here, can you please review? Thank you!

Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vijayg10 vijayg10 requested a review from elnyry-sam-k May 7, 2024 16:09
@vijayg10
Copy link
Contributor Author

vijayg10 commented May 7, 2024

@vijayg10 the test step is failing here, can you please review? Thank you!

fixed the issue, thanks.

@vijayg10 vijayg10 merged commit 13b99cb into main May 28, 2024
8 checks passed
@vijayg10 vijayg10 deleted the fix/pull-secret-reference branch May 28, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants