feat(mojaloop/#2963): create a sdk scheme adapter helm chart (#502) #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: added initial sdk-scheme-adapter folder with main readme * feat: ceate an sdk-scheme-adapter helm chart - added initial chart-service for sdk-scheme-adapter-svc - added parent sdk-scheme-adapter wrapper chart * deployment fixes * updates - added wait-for-redis - fixed env vars * fixes for ingress * fixes for ingress * cleanup of main values config for sdk-scheme-adapter-svc * fixes for sdk-scheme-adapter * clean up to sdk-scheme-adapter values * clean up to sdk-scheme-adapter values * updated readme with documentation * fix: for global vs local vars for kafka and redis - fixed global vs local assignment issues - updated documentation * fixes for configs * cleaned up configs * added 'sdk-scheme-adapter to package/update scripts * added sdk-scheme-adapter to lint script * cleaned up codeowners * bump chart version to v2 * updates for redis database support and kafka topic prefixes - added database to redis config and URI mapping - added chart name as a prefix to all sdk-scheme-adapter topics * bumped sdk-scheme-adapter to latest snapshot * Updated API_SERVER_* env configs to include DOMAIN_EVENT/COMMAND_EVENT prefix depending on context - Updated API_SERVER_* env configs to include DOMAIN_EVENT/COMMAND_EVENT prefix depending on context - updated serviceName on metric configs * typo on port
* chore: bump and validate sdk-scheme-adapter api-svc * chore: fix name in readme * bump to mojaloop-sim charts - bumped chart and dependencies - updated descriptions * updates to thirdparty charts Co-authored-by: Miguel de Barros <[email protected]>
…#503) feat(mojaloop/#2964): add three new simulator dfsps using sdk and ttk - mojaloop/project#2964 - added mojaloop-ttk-simulators parent wrapper chart that provides 3 simulators that are configurable for deployment - fixed configs with sdk-scheme-adapter to make them more configurable for the mojaloop-ttk-sim parent wrapper fix: "data: Too long: must have at most 1048576 bytes" error - `helm.go:84: [debug] Secret "sh.helm.release.v1.bulk.v1" is invalid: data: Too long: must have at most 1048576 bytes` <-- this error occurs because parent charts are including the "raw" child-* folders when they are packaged (i.e. copying unnecessary files), and are already being included in the "charts" folder as tgz packages. Fixed this by adding `chart-*` to all `.helmignore` files, and adding `.helmignore` files where missing. Co-authored-by: Vijay Kumar <[email protected]>
…y to mojaloop (#507) feat([mojaloop/2976](mojaloop/project#2976)): added mojaloop-ttk-simulators chart as dependency to mojaloop (#507) * feat: added mojaloop-ttk-simulators chart as dependency to mojaloop * feat: added helm test command * Updated README.md
* chore: bump sdk * chore: bump to release * chore: bump * chore: bump sdk
* feat: added jws support to sdk-scheme-adapter * chore: added checksums for jws keys in sdk chart
* feat(mojaloop/#2352): update and standardise helm charts to use networking v1 (#508) feat(mojaloop/#2352): update and standardise helm charts to use networking v1 - mojaloop/project#2352 # Notes This PR is re-created from #506 which includes some fixes based on tests on k8s v1.24 # Changes: ## Update the Chart.yaml's and standardise all charts to helm v3 (API v2) - move any dependencies in the requirements.yaml to Charts.yaml - update the apiVersion for helm in all the Charts.yaml to 2.0 - add the common dependency to each chart that already has an ingress - remove all requirements.lock - update maintainers in chart.yaml to include [email protected] - bump chart versions ## Update the ingress and networking API to v1 and standardise where possible - if the chart has an ingress template the chart is not on the exclusion list (see below) => the ingress template is updated to be a clone of the bitnami example (a version of what already exists in the charts repo) - updates the values files for the new ingress settings - ensure the updated values files have the correct hostname for the ingress - checks for paths and extra paths correctly allowed for (i.e. all charts with extraPaths or extraHosts are on e - ensure the updated values files have the correct port number for the ingress - update config/default.json files for values.ingress.api.host or similar to use .Values.ingress.hostname - _helper.tpl's updated to use correct ingress APIs and remove redundant ingress logic and templates ## General Maintenance - Fixed lint issue - Removed forensicloggingsidecar, centralenduserregistry, kube-system from lint scripts since they are no longer supported - Updated Maintainers list for each chart ## Exclusion list of charts - i.e. these charts are not yet standardised to the new ingress modeled on the bitnami example : - Any existing ingress in these charts has been updated "in place" rather than replaced with the newer standardised bitnami modeled chart. - So the ingress.yaml, config/*json, _helper.tpls , values.yaml files etc have been updated to use the latest ingress but they remain non-standard compared to the rest of the code-base. - "finance-portal-settlement-management", - "finance-portal", - ~"thirdparty"~, - ~"thirdparty/chart-tp-api-svc"~, - ~"thirdparty/chart-consent-oracle"~, - ~"thirdparty/chart-auth-svc"~, - ~"mojaloop-simulator"~, - "keycloak", - "monitoring", - "monitoring/promfana", - "monitoring/elk", - "ml-testing-toolkit/chart-keycloak", - "ml-testing-toolkit/chart-backend", - "ml-testing-toolkit/chart-frontend", - "ml-testing-toolkit/chart-connection-manager-backend", - "ml-testing-toolkit/chart-connection-manager-frontend" Co-authored-by: tdaly61 <[email protected]> Co-authored-by: Sam <[email protected]> * fix: als-admin api ingress service port (#511) - fixed als-admin api ingress service port from 4002 to 4001 - fixed formatting issues in for protocol_versions configs * fix(mojaloop/2995): update ttk-ui (#512) * chore: bumped up ttk-ui * chore: some change in appversion * fix: als-admin api ingress service port (#513) - fixed als api ingress service port fix from 4002/4001 to 80 - fixed formatting issues in for protocol_versions configs * chore: updated TTK and fixed some values * feat: added example backend chart for mojaloop (#517) feat: added example backend chart for mojaloop (#517) - mojaloop/project#3000 - updated mojaloop/values.yaml to include CONFIG section with YAML Anchor variables to make configurations easier - added example-mojaloop-backend for external backend dependencies to enable deployments on Kubernetes v1.22+ - updated shell helper scripts to include example-mojaloop-backend charts - updates CI config to add helm dependency repos and updated readme Co-authored-by: Miguel de Barros <[email protected]> * updates to chart appVersion description * fix: changed the default jws file path in sdk helm chart * fix: sdk helm values Co-authored-by: Miguel de Barros <[email protected]> Co-authored-by: tdaly61 <[email protected]> Co-authored-by: Sam <[email protected]>
…tion feat(mojaloop/3000): higher capacity bulk tests for load characterisation - mojaloop/project#3000 - upgraded sdk-scheme-adapter to v12.3.2
- merged master branch - added missing env vars for TTK Backend and TTK Sims
* fix: fixed some config for sdk bulk tests * chore: changed some env values for sdk-bulk tests
mdebarros
requested review from
elnyry-sam-k,
rmothilal and
vijayg10
as code owners
# Conflicts: # .changelog/release-v14.1.0.md # README.md # lint-charts.sh # ml-testing-toolkit/Chart.yaml # ml-testing-toolkit/chart-backend/Chart.yaml # mojaloop-simulator/Chart.yaml # mojaloop/Chart.yaml # mojaloop/values.yaml # package.sh # update-charts-dep.sh
vijayg10
reviewed
Nov 14, 2022
mojaloop-ttk-simulators/README.md
Outdated
Comment on lines
62
to
72
| ### Validation | ||
|
|
||
| - Open TTK UI for SIM1 on http://ttksim1.ttk1.test.mojaloop.live/admin/outbound_request | ||
| - Open TTK UI for SIM2 for monitoring the inbound requests as receiver http://ttksim2.ttk1.test.mojaloop.live/admin/monitoring | ||
| - Download the following test cases | ||
| https://github.com/mojaloop/sdk-scheme-adapter/blob/mvp/feat/%232809-local-end-to-end-func-tests/test/func/ttk-testcases/bulk-happy-path.json | ||
| - Import the test cases in TTK SIM1 | ||
| - Edit the first test case `TC-BHP1. Happy Path` | ||
| - Goto `Editor` tab on each request and deselect the checkbox `Override with Custom URL` | ||
| - Run the test cases by clicking on the `Send` button at the top right corner | ||
| - You should see all tests passed |
There was a problem hiding this comment.
I think these are temporary instructions at that time. We need to generalise these.
Comment on lines
+16
to
+19
| # TODO: Include the following dependencies: | ||
| # - SDK-Scheme-Adapter | ||
| # - Testing-Toolkit: Backend & Front-end (disabled by default) | ||
| # |
There was a problem hiding this comment.
This comment can be removed
Comment on lines
+16
to
+19
| # TODO: Include the following dependencies: | ||
| # - SDK-Scheme-Adapter | ||
| # - Testing-Toolkit: Backend & Front-end (disabled by default) | ||
| # |
There was a problem hiding this comment.
This comment can be removed
Comment on lines
+16
to
+19
| # TODO: Include the following dependencies: | ||
| # - SDK-Scheme-Adapter | ||
| # - Testing-Toolkit: Backend & Front-end (disabled by default) | ||
| # |
There was a problem hiding this comment.
This comment can be removed
Comment on lines
+5
to
+6
| # host: kafka | ||
| ## TODO: Remove this and uncomment the above line when merging to master |
There was a problem hiding this comment.
Need to handle this comment?
Comment on lines
+11
to
+12
| # host: redis | ||
| ## TODO: Remove this and uncomment the above line when merging to master |
There was a problem hiding this comment.
Need to handle this comment?
Comment on lines
+72
to
+90
| # host: 'ttksim1-specapi.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim1-specapi.ttk1.test.mojaloop.live' | ||
| adminApi: | ||
| # host: 'ttksim1.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim1.ttk1.test.mojaloop.live' | ||
| ml-testing-toolkit-frontend: | ||
| ingress: | ||
| enabled: true | ||
| hosts: | ||
| ui: | ||
| # host: ttksim1.ttk1.local | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: ttksim1.ttk1.test.mojaloop.live | ||
| config: | ||
| # API_BASE_URL: 'http://ttksim1.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| API_BASE_URL: 'http://ttksim1.ttk1.test.mojaloop.live' |
There was a problem hiding this comment.
Need to handle this comments. Ingress URLs are hardcoded.
Comment on lines
+148
to
+166
| # host: 'ttksim2-specapi.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim2-specapi.ttk1.test.mojaloop.live' | ||
| adminApi: | ||
| # host: 'ttksim2.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim2.ttk1.test.mojaloop.live' | ||
| ml-testing-toolkit-frontend: | ||
| ingress: | ||
| enabled: true | ||
| hosts: | ||
| ui: | ||
| # host: 'ttksim2.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim2.ttk1.test.mojaloop.live' | ||
| config: | ||
| # API_BASE_URL: 'http://ttksim2.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| API_BASE_URL: 'http://ttksim2.ttk1.test.mojaloop.live' |
There was a problem hiding this comment.
Need to handle this comment.
Comment on lines
+223
to
+241
| # host: 'ttksim3-specapi.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim3-specapi.ttk1.test.mojaloop.live' | ||
| adminApi: | ||
| # host: 'ttksim3.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim3.ttk1.test.mojaloop.live' | ||
| ml-testing-toolkit-frontend: | ||
| ingress: | ||
| enabled: true | ||
| hosts: | ||
| ui: | ||
| # host: 'ttksim3.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| host: 'ttksim3.ttk1.test.mojaloop.live' | ||
| config: | ||
| # API_BASE_URL: 'http://ttksim3.ttk1.local' | ||
| ## TODO: Remove this and uncomment the above line when merging to master | ||
| API_BASE_URL: 'http://ttksim3.ttk1.test.mojaloop.live' |
There was a problem hiding this comment.
Need to handle this comment?
- added new pre-test ml-ttk-test-setup-sdk-bulk - shortened ml-testing-toolkit-cli configMaps and volumes to accomodate slightly longer names - fixed ttk-sim readme, and added note to address manual testing steps - fixes for mojaloop NOTES.txt
TODO: fix this in v14.1.0 release branch
|
Vijay seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
Most of these changes are already merged as part the PR #509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: added initial sdk-scheme-adapter folder with main readme
feat: ceate an sdk-scheme-adapter helm chart
deployment fixes
updates
fixes for ingress
fixes for ingress
cleanup of main values config for sdk-scheme-adapter-svc
fixes for sdk-scheme-adapter
clean up to sdk-scheme-adapter values
clean up to sdk-scheme-adapter values
updated readme with documentation
fix: for global vs local vars for kafka and redis
fixes for configs
cleaned up configs
added 'sdk-scheme-adapter to package/update scripts
added sdk-scheme-adapter to lint script
cleaned up codeowners
bump chart version to v2
updates for redis database support and kafka topic prefixes
bumped sdk-scheme-adapter to latest snapshot
Updated API_SERVER_* env configs to include DOMAIN_EVENT/COMMAND_EVENT prefix depending on context