-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thirdparty): add thirdparty support to mojaloop-simulator chart #456
feat(thirdparty): add thirdparty support to mojaloop-simulator chart #456
Conversation
|
||
# Path to JWS signing key (private key of THIS DFSP) | ||
JWS_SIGNING_KEY_PATH: "/jwsSigningKey/private.key" # do not change this unless you know what you are doing - this will break the chart | ||
JWS_SIGNING_KEY_PATH: "/jwsSigningKey.key" # do not configure- will break the chart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Open a ticket for this - it's masking an insecure secret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to issue: mojaloop/project#2558
Thanks @lewisdaly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Please don't forget to create the issue as discussed.
Thanks @mdebarros will do |
closes mojaloop/project#2532
Instead of defining a new chart, I decided to add an optional deployment of the
thirdparty-sdk
component to the existing mojaloop-simulator chart to keep the maintenance burden as low as possible.The thirdparty-sdk is disabled by default, but you can turn it on when specifying a participant in the mojaloop-simulator values.yaml file like so: