Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/827 Integrate Event Framework #13

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Feature/827 Integrate Event Framework #13

merged 3 commits into from
Oct 21, 2019

Conversation

ggrg
Copy link
Member

@ggrg ggrg commented Oct 18, 2019 •
edited
Loading

  • Changed default port to 50055
  • Bugfix: Added finishedTimestamp: undefined when createChildSpanFromContext !!!
  • Shorter debug log for Buffer data prior gRPC call
  • Upgraded dependencies

@ggrg ggrg self-assigned this Oct 18, 2019
@ggrg ggrg requested review from vgenev, mdebarros and ramirogm October 18, 2019 21:46
@mdebarros mdebarros mentioned this pull request Oct 18, 2019
Closed
57 tasks
vgenev
vgenev reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@vgenev vgenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't understand the bug the fix is for.

vgenev
vgenev suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@vgenev vgenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't consider that as a bug.

@ggrg ggrg requested a review from vgenev October 21, 2019 10:35
vgenev
vgenev approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@vgenev vgenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy

@ggrg ggrg merged commit 47a40dd into mojaloop:master Oct 21, 2019
@ggrg ggrg deleted the feature/827IntegrateEventFramework branch October 21, 2019 10:41
@ggrg ggrg restored the feature/827IntegrateEventFramework branch February 27, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgenev vgenev vgenev approved these changes

@mdebarros mdebarros Awaiting requested review from mdebarros

@ramirogm ramirogm Awaiting requested review from ramirogm

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@rmothilal rmothilal Awaiting requested review from rmothilal

Assignees

@ggrg ggrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggrg @vgenev