Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1513: Fix errors with quoting service sequence diagram #251

Merged
merged 2 commits into from
Aug 21, 2020
Merged

#1513: Fix errors with quoting service sequence diagram #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9535b7
Fix errors with quoting service sequence diagram
oderayi Aug 13, 2020
dc24363
Merge branch 'master' into bugfix/#1513-refactor-wrong-sequence-diagr…
elnyry-sam-k Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mojaloop-technical-overview/quoting-service/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Quoting Service
# Quoting Service Overview
The **Quoting Service** (**QS**) _(refer to section `5.1`)_ as per the [Mojaloop {{ book.importedVars.mojaloop.spec.version }} Specification]({{ book.importedVars.mojaloop.spec.uri.doc }}) implements the following use-cases:
* P2P Transfers

Expand Down
14 changes: 8 additions & 6 deletions ...oop-technical-overview/quoting-service/assets/diagrams/sequence/seq-quotes-1.0.0.plantuml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ note over "Payer DFSP", Switch: Payer DFSP requests quote from Payee DFSP
"Payer DFSP" -\ Switch: POST /quotes
Switch --/ "Payer DFSP": 202 Accepted
Switch -> Switch: Validate Quote Request

alt quote is valid

Switch -> Switch: Persist Quote Data
note over Switch, "Payee DFSP": Switch forwards quote request to Payee DFSP\n<Payer based Rules>
Switch -\ "Payee DFSP": POST /quotes
Expand Down Expand Up @@ -48,19 +50,19 @@ alt quote is valid

note over "Payee DFSP", Switch: Payee DFSP returns error to Switch

"Payee DFSP" -\ Switch: POST quotes/{ID}/error
Switch --/ "Payee DFSP": 202 Accepted
"Payee DFSP" -\ Switch: PUT quotes/{ID}/error
Switch --/ "Payee DFSP": 200 OK
Switch -> Switch: Persist error data

note over "Payer DFSP", Switch: Switch returns error to Payer DFSP

Switch -\ "Payer DFSP": POST quotes/{ID}/error
"Payer DFSP" --/ Switch: 202 Accepted
Switch -\ "Payer DFSP": PUT quotes/{ID}/error
"Payer DFSP" --/ Switch: 200 OK

end
else quote invalid
note over "Payer DFSP", Switch: Switch returns error to Payer DFSP
Switch -\ "Payer DFSP": POST quotes/{ID}/error
"Payer DFSP" --/ Switch: 202 Accepted
Switch -\ "Payer DFSP": PUT quotes/{ID}/error
"Payer DFSP" --/ Switch: 200 OK
end
@enduml
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "documentation",
"version": "11.0.1",
"version": "11.0.2",
"description": "Mojaloop Documentation GitBook Project",
"dependencies": {
"express": "4.17.1",
Expand Down