create settlement model on startup #320
Conversation
src/shared/setup.js
Outdated
|
|
||
| const createSettlementModels = async function (settlementModels = []) { | ||
| try { | ||
| // Get the existing settlement models |
There was a problem hiding this comment.
do we really need these comments?
src/shared/setup.js
Outdated
| } | ||
|
|
||
| // Find any new settlement models to be added | ||
| const newSettlementModels = settlementModels.filter(a => !existingSettlementModels.some(b => b.name === a.name)) |
There was a problem hiding this comment.
refactor into small function (naming should help clarify) without need for comments
| for (const settlementModel of newSettlementModels) { | ||
| Logger.info(`Creating settlement model: ${JSON.stringify(settlementModel)}`) | ||
| const opts = { url, method: 'POST', data: settlementModel } | ||
| await request(opts) |
There was a problem hiding this comment.
not sure how many settlementModels are we going to create , but this could become a await Promise.all if there are a lot of them?
src/shared/setup.js
Outdated
| /** | ||
| * @function createSettlementModels | ||
| * | ||
| * @description Creates settlement models defined by config is not exists in database |
There was a problem hiding this comment.
if it does not exist in database
src/shared/setup.js
Outdated
| const response = await request(opts) | ||
| const existingSettlementModels = response.data | ||
|
|
||
| if ((settlementModels == null || settlementModels.length < 1) && existingSettlementModels.length < 1) { |
There was a problem hiding this comment.
refactor if (!hasAtLeastOneSettlementModel) function helps with readability.
… to integration test runner.
|
Just an update that we are testing changes on settlementModels creation at startup that will address similarly but with a wider reaching solution for the community. |
|
@claudio-viola thanks for getting in touch- what time-frame are you expecting that to be completed, and is the implementation visible in GH at the moment? |
|
Shashi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Summary: