feat(mojaloop/#2092)!: upgrade nodeJS version for core services #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
changed the title
kleyow
changed the title
mdebarros
requested changes
May 19, 2022
There was a problem hiding this comment.
Please align linting to https://github.com/mojaloop/typescript-svc-template.
Note that some updates are needed to the the template, which have been made in this PR: mojaloop/event-sdk#67
mdebarros
approved these changes
May 19, 2022
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - removed unused files - removed unused dependencies - re-aligned package.json - added replace dependency - added IGNORE and test/result patterns to gitignore - removed .versionrc.js for consistency
- renamed ncurc.json to js so TODO comment could be added - added @mojaloop/* dependencies as DEV dependencies. This will ensure that the versioning will be managed by dep:update script - fixed issue with pretest script using npx instead of npm - also added an emitter event for disconnects that was missing from the consumer & producer implementations
mdebarros
previously approved these changes
May 19, 2022
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
Notes:
node-rdkafka>=2.11 to support node 16 which one of the 3ppi services depends on.BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!