Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#1140 add span for send request #172

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Feature/#1140 add span for send request #172

merged 5 commits into from
Jan 24, 2020

Conversation

vgenev
Copy link
Contributor

@vgenev vgenev commented Jan 24, 2020

Added metrics for Callback.sendRequest

@vgenev vgenev self-assigned this Jan 24, 2020
mdebarros
mdebarros previously approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vgenev vgenev requested review from mdebarros, yosheeck, AlbogastAman, oderayi and elnyry-sam-k and removed request for AlbogastAman January 24, 2020 13:04
mdebarros
mdebarros approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

rmothilal
rmothilal approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@vgenev vgenev merged commit f5acac5 into mojaloop:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmothilal rmothilal rmothilal approved these changes

@mdebarros mdebarros mdebarros approved these changes

@ggrg ggrg Awaiting requested review from ggrg

@yosheeck yosheeck Awaiting requested review from yosheeck

@oderayi oderayi Awaiting requested review from oderayi

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

Assignees

@vgenev vgenev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgenev @mdebarros @rmothilal