Feature/827 Integrate Event Framework

[ggrg]

Changes in this PR:

• Updated Event.Types & Event.Actions
• Added getCircularReplacer() to be used as a second argument for JSON.stringify()
• Unit tests for Util.getCircularReplacer()
• event-sdk dependency upgrade

[mdebarros]

Any reason why we are not considering something like --> https://www.npmjs.com/package/jspon to handle circular references?

[ggrg]

@mdebarros, I prefer to keep things simple and to me the solution from MDN beats all other, when it comes to using JSON.stringify()

[ggrg]

@rmothilal, I'm trying to fix an issue with JSON.stringify() in quoting-service here.

[ggrg]

@mdebarros, if there's anything to consider, it is to ban the usage of JSON.stringify and somehow impose it (in favour of CentralServices.Util.stringify) Also, the alternative for deep cloning - JSON.parse(JSON.stringify(obj)) is still with TODO comments:

central-services-shared/src/util/index.js:

/**
 * Method to provide object cloning
 *
 * TODO:
 *  Implement a better deep copy method
 *
 * @param value
 * @returns {any}
 */
const clone = (value) => {
  return _.cloneDeep(value)
}

[mdebarros]

@rmothilal, I'm trying to fix an issue with JSON.stringify() in quoting-service here.

@ggrg : I assume you have tested this solution on quoting-service right? Also, why has not been an issue previously?

[ggrg]

@rmothilal, I'm trying to fix an issue with JSON.stringify() in quoting-service here.

@ggrg : I assume you have tested this solution on quoting-service right? Also, why has not been an issue previously?

Yes, I tested it, and also wrote unit tests, which also do. I guess it was not an issue previously, because it was not tested! Checkout master, trigger that branch and you'll see the issue.

[gibaros]

Approved

[rmothilal]

Happy

[vgenev]

Any reason why we are not considering something like --> https://www.npmjs.com/package/jspon to handle circular references?

also util.inspect removes the circular reference but replaces it with [Circular].

[ggrg]

Any reason why we are not considering something like --> https://www.npmjs.com/package/jspon to handle circular references?

also util.inspect removes the circular reference but replaces it with [Circular].

Because "The output of util.inspect may change at any time and should not be depended upon programmatically." from here.