Remove unused code and dependencies (#144)

- Removed unused code - Removed unused dependencies - Updated dependencies - Bumped version
mojaloop · Dec 11, 2019 · 2e6c9f6 · 2e6c9f6
1 parent 77a2ae5
commit 2e6c9f6
Show file tree

Hide file tree

Showing 8 changed files with 360 additions and 580 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -41,7 +41,6 @@
   },
   "homepage": "https://github.com/mojaloop/central-services-shared#readme",
   "dependencies": {
-    "@mojaloop/central-services-stream": "8.4.0",
     "@hapi/catbox": "10.2.3",
     "@hapi/catbox-memory": "4.1.1",
     "@mojaloop/central-services-error-handling": "8.6.2",
@@ -51,20 +50,18 @@
     "base64url": "3.0.1",
     "clone": "2.1.2",
     "data-urls": "1.1.0",
-    "glob": "7.1.6",
     "immutable": "3.8.2",
     "lodash": "4.17.15",
     "mustache": "3.1.0",
     "raw-body": "2.4.1"
   },
   "devDependencies": {
-    "@modusbox/mojaloop-sdk-standard-components": "0.0.39",
     "@hapi/hapi": "18.4.0",
     "@hapi/joi": "16.1.8",
     "chance": "1.1.4",
     "faucet": "0.0.1",
     "npm-audit-resolver": "2.1.0",
-    "npm-check-updates": "3.2.2",
+    "npm-check-updates": "4.0.1",
     "nyc": "14.1.1",
     "pre-commit": "1.2.2",
     "proxyquire": "2.1.3",

diff --git a/src/util/hapi/plugins/rawPayloadToDataUri.js b/src/util/hapi/plugins/rawPayloadToDataUri.js
@@ -81,7 +81,7 @@ module.exports.plugin = {
                 request = requestRawPayloadTransform(request, rawBuffer)
               }
               return h.continue
-            }).catch(e => {
+            }).catch(() => {
               return h.continue
             })
         }

diff --git a/src/util/time.js b/src/util/time.js
@@ -1,8 +1,8 @@
 'use strict'
 
-const sleep = (milliseconds = 10, debug = false, caller = null, reason = null) => {
+const sleep = (milliseconds = 10) => {
   const start = new Date().getTime()
-  while (1) {
+  while (true) {
     if ((new Date().getTime() - start) > milliseconds) {
       break
     }

diff --git a/test/unit/util/comparators/duplicateCheckComparator.test.js b/test/unit/util/comparators/duplicateCheckComparator.test.js
@@ -80,7 +80,7 @@ Test('Duplicate check comparator', dccTest => {
         })
         const id = 1
         const object = { key: 'value' }
-        const getDuplicateDataFuncOverride = async (id) => { return Promise.resolve(null) }
+        const getDuplicateDataFuncOverride = async () => { return Promise.resolve(null) }
         const saveHashFuncOverride = async () => { return true }
 
         const expected = {

diff --git a/test/unit/util/hapi/plugins/eventPlugin.test.js b/test/unit/util/hapi/plugins/eventPlugin.test.js
@@ -57,7 +57,7 @@ Test('Event plugin test', async (pluginTest) => {
       server.route({
         method: 'POST',
         path: '/',
-        handler: (request, h) => {
+        handler: (request) => {
           span = request.span
           return 'testing'
         },
@@ -89,7 +89,7 @@ Test('Event plugin test', async (pluginTest) => {
       server.route({
         method: 'POST',
         path: '/',
-        handler: (request, h) => {
+        handler: (request) => {
           span = request.span
           return 'testing'
         },
@@ -129,7 +129,7 @@ Test('Event plugin test', async (pluginTest) => {
       server.route({
         method: 'POST',
         path: '/',
-        handler: (request, h) => {
+        handler: (request) => {
           span = request.span
           return 'testing'
         },
@@ -158,7 +158,7 @@ Test('Event plugin test', async (pluginTest) => {
       server.route({
         method: 'POST',
         path: '/',
-        handler: (request, h) => {
+        handler: (request) => {
           span = request.span
           throw Error('testing')
         },
@@ -190,7 +190,7 @@ Test('Event plugin test', async (pluginTest) => {
       server.route({
         method: 'POST',
         path: '/',
-        handler: (request, h) => {
+        handler: (request) => {
           span = request.span
           throw Error('testing')
         },

diff --git a/test/unit/util/hapi/plugins/eventPluginIsolated.test.js b/test/unit/util/hapi/plugins/eventPluginIsolated.test.js
@@ -55,7 +55,7 @@ Test('Event plugin test', async (pluginTest) => {
       server.route({
         method: 'POST',
         path: '/',
-        handler: (request, h) => {
+        handler: (request) => {
           span = request.span
           throw Error('testing')
         },

diff --git a/test/unit/util/hapi/plugins/rawPayloadToDataUri.test.js b/test/unit/util/hapi/plugins/rawPayloadToDataUri.test.js
@@ -11,7 +11,7 @@ const init = async (options) => {
   server.route({
     method: 'POST',
     path: '/',
-    handler: (request, h) => {
+    handler: (request) => {
       return {
         payload: request.payload,
         dataUri: request.dataUri,