-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/1218 Settlement Model Handler Design #607
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added migrations and seeds * WIP * Remove unused code (mojaloop#504) * Remove unused code * Update dependencies * Maintenance update (mojaloop#505) - Upgraded Event-SDK - Version bump * Upgraded central-services-stream for #1114KafkaErrorLocalQueuefull fix (mojaloop#511) * package.json and package-lock * Changes following peer review * Added settlementWindowContent.settlementId Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Miguel de Barros <[email protected]>
* Added additional window states * Change to currentStateId. Dependencies update
* Seed settlementModel samples. Deps * settlementModel.name unique index * Re-run failed integration tests. Added hapi-swagger to ncu ignore list
Disabled settlementModel seeds (mojaloop#564)
* Changes: * 1179-Create SettlementModel API new code * Address PR comments: - Used central-services-shared for the enums - handled duplicate insert to not return internal server error and sql statement - Fixed validations on the routes.js - Changed settlementCurrency to currency on the request - Changed type to ledgerAccountType on the request * 1179-Create SettlementModel API Cleaned up the code * Triggering build * Applied standard.JS
* Added settlementModel.autoPositionReset. Dependencies update * Fix /settlementModel to plural /settlementModels * Fix npm vulnerabilities
mojaloop#588) * Changes for story #1207: - Added PUT/GET routes with Joi validations - Included #1211 autoPositionReset property to GET requests - Created handler scripts - Implemented DAO scripts - Updated Unit tests * Fixed npm audit errors * 1207- Implement settlementModels management - GET and PUT operations * Moved enums to central-services-shared * Updated central-services-shared version
* Implemented settlement model definition validation. Node upgrade * 9.1.2-snapshot * Fix coverage * Change as per PR request
Closed
19 tasks
settlement model unique constraint (mojaloop#606)
…to feature/1218SettlementModelHandler
…ure/1218SettlementModelHandler
rmothilal
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy
I have pushed the above as a branch to mojaloop/central-ledger, so that the team will be able to manage it in my absence after the DA review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please, ignore the long lists of commits below. It's due to recent merge of settlement-v2 and re-basing this PR to master