Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/1218 Settlement Model Handler Design #607

Closed
wants to merge 24 commits into from

Conversation

ggrg
Copy link
Member

@ggrg ggrg commented Feb 20, 2020

  • Added transferParticipantStateChange table and related FKs and indexes

Note: Please, ignore the long lists of commits below. It's due to recent merge of settlement-v2 and re-basing this PR to master

ggrg and others added 19 commits January 6, 2020 16:07
* Added migrations and seeds

* WIP

* Remove unused code (mojaloop#504)

* Remove unused code

* Update dependencies

* Maintenance update (mojaloop#505)

- Upgraded Event-SDK
- Version bump

* Upgraded central-services-stream for #1114KafkaErrorLocalQueuefull fix (mojaloop#511)

* package.json and package-lock

* Changes following peer review

* Added settlementWindowContent.settlementId

Co-authored-by: Steven Oderayi <[email protected]>
Co-authored-by: Miguel de Barros <[email protected]>
* Added additional window states

* Change to currentStateId. Dependencies update
* Seed settlementModel samples. Deps

* settlementModel.name unique index

* Re-run failed integration tests. Added hapi-swagger to ncu ignore list
* Changes:

* 1179-Create SettlementModel API new code

* Address PR comments:
- Used central-services-shared for the enums
- handled duplicate insert to not return internal server error and sql statement
- Fixed validations on the routes.js
- Changed settlementCurrency to currency on the request
- Changed type to ledgerAccountType on the request

* 1179-Create SettlementModel API

Cleaned up the code

* Triggering build

* Applied standard.JS
* Added settlementModel.autoPositionReset. Dependencies update

* Fix /settlementModel to plural /settlementModels

* Fix npm vulnerabilities
mojaloop#588)

*    Changes for story #1207:

			- Added PUT/GET routes with Joi validations
			- Included #1211 autoPositionReset property to GET requests
			- Created handler scripts
			- Implemented DAO scripts
			- Updated Unit tests

* Fixed npm audit errors

* 1207- Implement settlementModels management - GET and PUT operations

 * Moved enums to central-services-shared
 * Updated central-services-shared version
* Implemented settlement model definition validation. Node upgrade

* 9.1.2-snapshot

* Fix coverage

* Change as per PR request
@ggrg ggrg changed the base branch from settlement-v2 to master February 27, 2020 23:12
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@ggrg
Copy link
Member Author

ggrg commented Feb 28, 2020

I have pushed the above as a branch to mojaloop/central-ledger, so that the team will be able to manage it in my absence after the DA review.

@ggrg ggrg closed this Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants