Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/#2374): ALS is sending out multiple requests to participants for both Oracle records that match non-subId and subId result set: #425

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Aug 17, 2021

fix(mojaloop/#2374): ALS is sending out multiple requests to participants for both Oracle records that match non-subId and subId result set:

  • Corrected fix for ALS is sending out multiple requests to participants for both Oracle records that match non-subId and subId result set for mojaloop/#2374
  • Fixed filter for sub-id match
  • Added unit test to handle when sub-id is provided but no match is not found

Maintenance changes:

  • changed circleci config to use .Environment.CIRCLE_SHA1 instead of hash of the package.json for dependency caching

…ants for both Oracle records that match non-subId and subId result set

- Updated gitignore with devspace patterns
- Fix for ALS is sending out multiple requests to participants for both Oracle records that match non-subId and subId result set [mojaloop/#2374](mojaloop/project#2374)
- Updated unit tests for [mojaloop/#2374](mojaloop/project#2374)
 fix
- Updated latest dependencies
- Fixes for audit-resolve

--------------------------------------------------
 yargs-parser needs your attention.

[ low ] Prototype Pollution
 vulnerable versions <13.1.2 || >=14.0.0 <15.0.1 || >=16.0.0 <18.1.2 found in:
 - dependencies: @mojaloop/central-services-shared>widdershins>yargs>yargs-parser

> Outcome: Ignored for a week
> Impact: Minimal as the dependencies are used for the Developer Documentation end-point
- Fixed filter for sub-id match
- Added unit test to handle when sub-id match is not found
…nto fix/#2374-ALS-is-sending-out-multiple-requests-to-participants-for-both-Oracle-records-that-match-non-subId-and-subId-result-set

# Conflicts:
#	src/domain/parties/parties.js
#	test/unit/domain/parties/parties.test.js
@mdebarros
Copy link
Member Author

GP tests results for this change:

--------------------FINAL REPORT--------------------
Test Suite:GP Tests
Environment:Development
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2064                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2064                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 446                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 99                            │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Tue, 17 Aug 2021 14:16:59 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Tue, 17 Aug 2021 14:19:16 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 137682 ms                     │
└───────────────────┴───────────────────────────────┘
TTK-Assertion-Report-multi-2021-08-17T14:19:16.971Z.html was generated
Terminate with exit code 0

@mdebarros mdebarros changed the title fix(mojaloop/#2374): als is sending out multiple requests to participants for both oracle records that match non sub id and sub id result set fix(#2358-2): firstname, middlename and lastname regex not supporting myanmar script unicode strings Aug 17, 2021
@mdebarros mdebarros marked this pull request as ready for review August 17, 2021 15:08
@mdebarros mdebarros self-assigned this Aug 17, 2021
@mdebarros mdebarros merged commit 7a61510 into mojaloop:master Aug 17, 2021
@elnyry-sam-k elnyry-sam-k changed the title fix(#2358-2): firstname, middlename and lastname regex not supporting myanmar script unicode strings fix(mojaloop/#2374): ALS is sending out multiple requests to participants for both Oracle records that match non-subId and subId result set: Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants