Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1243 #1245 incorrect http and status code #253

Conversation

rmothilal
Copy link
Contributor

Updated dependecies as well as event-sdk

Henk Kodde and others added 30 commits May 29, 2019 14:11
…ervice into feature/#656ImplTesting

# Conflicts:
#	package.json
#	test/unit/handlers/oracles.test.js
removed validator file as it isn't used may be required in MSISDN oracle as it validated mobile number formats
Fixes for sonarQube code sanity i.e removing function names that aren't needed, changing let to const, reordering functions in file
Changed unique constraint on oracleEndpoint which is now working correctly
return undefined for currency when it is not available
# Conflicts:
#	package-lock.json
#	package.json
# Conflicts:
#	src/handlers/parties/{Type}/{ID}/error.js
# Conflicts:
#	package-lock.json
#	package.json
@rmothilal rmothilal self-assigned this Mar 2, 2020
package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "account-lookup-service",
"description": "Account Lookup Service is used to validate Party and Participant lookups",
"version": "9.2.3",
"version": "9.2.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go to 9.3.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated @elnyry

@rmothilal rmothilal requested a review from elnyry-sam-k March 2, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants